View Issue Details

IDProjectCategoryView StatusLast Update
0034135FPCPackagespublic2018-08-15 20:53
ReporterAndrea UrbaniAssigned ToMichael Van Canneyt 
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Platformx64OSWindowsOS Version10
Product Version3.0.4Product Build39617 
Target Version3.2.0Fixed in Version3.1.1 
Summary0034135: [ PATCH ] TOracleConnection.UpdateIndexDefs does not recognise indexes built on more fields
DescriptionMistake in the code: it is appending to "Fields" the options (qry.fields[2].asstring) instead of the field name (qry.fields[1].asstring)
Steps To ReproduceJust create a primary key built on more fields and try to update the record or print out the query.ServerIndexDefs content
Additional Informationpackages\fcl-db\src\sqldb\oracle
TagsNo tags attached.
Fixed in Revision39618
FPCOldBugId
FPCTarget
Attached Files
  • oracleconnection.pp.patch (457 bytes)
    Index: oracleconnection.pp
    ===================================================================
    --- oracleconnection.pp	(revision 39617)
    +++ oracleconnection.pp	(working copy)
    @@ -1203,7 +1203,7 @@
         qry.next;
         while (name = qry.fields[0].asstring) and (not qry.eof) do
           begin
    -      Fields := Fields + ';' + trim(qry.Fields[2].asstring);
    +      Fields := Fields + ';' + trim(qry.Fields[1].asstring);
           qry.next;
           end;
         end;
    

Activities

Andrea Urbani

2018-08-15 18:00

reporter  

oracleconnection.pp.patch (457 bytes)
Index: oracleconnection.pp
===================================================================
--- oracleconnection.pp	(revision 39617)
+++ oracleconnection.pp	(working copy)
@@ -1203,7 +1203,7 @@
     qry.next;
     while (name = qry.fields[0].asstring) and (not qry.eof) do
       begin
-      Fields := Fields + ';' + trim(qry.Fields[2].asstring);
+      Fields := Fields + ';' + trim(qry.Fields[1].asstring);
       qry.next;
       end;
     end;

Michael Van Canneyt

2018-08-15 19:18

administrator   ~0110064

Checked and applied patch, thank you very much !

Please test and close if OK.

Issue History

Date Modified Username Field Change
2018-08-15 18:00 Andrea Urbani New Issue
2018-08-15 18:00 Andrea Urbani File Added: oracleconnection.pp.patch
2018-08-15 18:12 Michael Van Canneyt Assigned To => Michael Van Canneyt
2018-08-15 18:12 Michael Van Canneyt Status new => assigned
2018-08-15 19:18 Michael Van Canneyt Fixed in Revision => 39618
2018-08-15 19:18 Michael Van Canneyt Note Added: 0110064
2018-08-15 19:18 Michael Van Canneyt Status assigned => resolved
2018-08-15 19:18 Michael Van Canneyt Fixed in Version => 3.1.1
2018-08-15 19:18 Michael Van Canneyt Resolution open => fixed
2018-08-15 19:18 Michael Van Canneyt Target Version => 3.2.0
2018-08-15 20:53 Andrea Urbani Status resolved => closed