View Issue Details

IDProjectCategoryView StatusLast Update
0034241FPCPackagespublic2018-09-10 12:58
ReporterChristo CrauseAssigned ToMichael Van Canneyt 
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version3.1.1Product Build 
Target Version3.2.0Fixed in Version3.3.1 
Summary0034241: fpmkunit - TDependencies.AddInclude doesn't actually change file extension if needed
DescriptionThe method TDependencies.AddInclude has functionality to append '.inc' to the file name passed into the method if it doesn't have a file extension by using the ChangeFileExt function. Note that the result of the changed filename needs to be assigned to a variable, but this isn't done. Refer to the code below from fpmkunit.pp
Steps To ReproduceFunction TDependencies.AddInclude(Const Value : String;const CPUs:TCPUs;const OSes:TOSes) : TDependency;
Var
  N : String;
begin
  N:=FixPath(Value, False);
  if ExtractFileExt(N)='' then
    ChangeFileExt(N,IncExt); << notice that function value is not assigned to N
Additional InformationThe fix is simple:

  if ExtractFileExt(N)='' then
    N := ChangeFileExt(N,IncExt);
TagsNo tags attached.
Fixed in Revision39713
FPCOldBugId
FPCTarget
Attached Files

Activities

Michael Van Canneyt

2018-09-08 12:16

administrator   ~0110556

Fixed using suggestion, thanks for reporting!

Christo Crause

2018-09-10 12:58

reporter   ~0110609

Thanks.

Issue History

Date Modified Username Field Change
2018-09-08 10:50 Christo Crause New Issue
2018-09-08 12:16 Michael Van Canneyt Fixed in Revision => 39713
2018-09-08 12:16 Michael Van Canneyt Note Added: 0110556
2018-09-08 12:16 Michael Van Canneyt Status new => resolved
2018-09-08 12:16 Michael Van Canneyt Fixed in Version => 3.3.1
2018-09-08 12:16 Michael Van Canneyt Resolution open => fixed
2018-09-08 12:16 Michael Van Canneyt Assigned To => Michael Van Canneyt
2018-09-08 12:16 Michael Van Canneyt Target Version => 3.2.0
2018-09-10 12:58 Christo Crause Note Added: 0110609
2018-09-10 12:58 Christo Crause Status resolved => closed