View Issue Details

IDProjectCategoryView StatusLast Update
0034288FPCFCLpublic2018-09-16 14:04
ReporterJohn KozikopoulosAssigned ToMichael Van Canneyt 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version3.0.4Product Build 
Target Version3.2.0Fixed in Version3.3.1 
Summary0034288: TFPExressionParser wrong test for failure
Descriptionunit FpExprPars
Class TFPExpressionParser
Method Primitive
Line No 1721.

The code reads

1716 if TryStrToInt64(CurrentToken,I) then
1717 Result:=TFPConstExpression.CreateInteger(I)
1718 else
1719 begin
1720 Val(CurrentToken,X,C);
1721 If (I=0) then
1722 Result:=TFPConstExpression.CreateFloat(X)
1723 else
1724 ParserError(Format(SErrInvalidFloat,[CurrentToken]));
1725 end;
    end
the line
  If (I=0) then
should read
  If (C=0) then
Steps To Reproduceno steps
TagsNo tags attached.
Fixed in Revision39758
FPCOldBugId
FPCTarget
Attached Files

Activities

John Kozikopoulos

2018-09-16 13:48

reporter   ~0110783

Last edited: 2018-09-16 13:48

View 2 revisions

and my summary is wrong should be test for success or wrong test.Apologies.

Michael Van Canneyt

2018-09-16 14:04

administrator   ~0110784

Fixed, thanks for reporting !

Issue History

Date Modified Username Field Change
2018-09-16 13:47 John Kozikopoulos New Issue
2018-09-16 13:48 John Kozikopoulos Note Added: 0110783
2018-09-16 13:48 John Kozikopoulos Note Edited: 0110783 View Revisions
2018-09-16 14:04 Michael Van Canneyt Fixed in Revision => 39758
2018-09-16 14:04 Michael Van Canneyt Note Added: 0110784
2018-09-16 14:04 Michael Van Canneyt Status new => resolved
2018-09-16 14:04 Michael Van Canneyt Fixed in Version => 3.3.1
2018-09-16 14:04 Michael Van Canneyt Resolution open => fixed
2018-09-16 14:04 Michael Van Canneyt Assigned To => Michael Van Canneyt
2018-09-16 14:04 Michael Van Canneyt Target Version => 3.2.0