|
|
replacedlg.png (5,110 bytes) |
|
|
Yeah, it's horrible indeed. Not sure it's related to 0033528 though. |
|
|
It is related to 0033528 in the sense that now the top position of the ReplaceDialog is at (0, 0) and the dialog can be moved with the mouse. But you are right, 0033528 certainly did not cause the issue because it has been there for a long time. |
|
|
There is something iffy going on with TReplaceDialog in the IDE. If you test the dialog then this happens with TFindDialog: - Execute is called - Execute calls CalcPosition (in CalcPosition I now have a check for csDesigning and simply set Position to poScreenCenter) - After CalcPosition Execute calls FFindForm.Show Now I put in a blocking ShowMessage in CalcPosition for quick debugging. For TFindDialog this works as expected. I see the ShowMessage and the dialog only appears after I click the ShowMessage away. For TReplaceDialog however this does NOT happen. Execute is called, the ShowMessage appears, but simultaneously (?) the TReplaceDialog is shown. And by the look of that form SetLayout has not been called yet, which is rather strange, since that should be called in the CreateNew constructor for TReplaceDialogForm. |
|
|
Inside CalcPosition I can see that aForm.Showing is False in the case of TFindDialog (as expected) but True for TReplaceDialog. The TReplaceDialog seems to be shown before CalcPosition returns. I also can see that TReplaceDialog.SetLayout is being called, which makes this even more a mystery to me. |
|
|
And all this insanity goes away by changing this in TReplaceDialog.CreateForm: Result := TReplaceDialogForm.CreateNew(Self,Options); into Result := TReplaceDialogForm.CreateNew(nil,Options); And yes, in TFindDialog.CreateForm you find: // do not use Self as Owner, otherwise as desgntime this will not work ... Result := TFindDialogForm.CreateNew(nil,Options); I really don't know how this (retruning prematurely from a function that has a blocking showmessage) can happen though. |
|
|
Please test and close if OK. |
|
|
Wow! Thank you. |
- Anonymous
