View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0034533 | FPC | Textmode IDE | public | 2018-11-10 11:58 | 2019-01-02 01:12 |
Reporter | Marģers | Assigned To | Florian | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Platform | x86_64 | OS | linux | ||
Product Version | 3.3.1 | ||||
Fixed in Version | 3.3.1 | ||||
Summary | 0034533: Options -> Save As dialog Save Options has wrong button caption "Open" | ||||
Description | Added patch to replace "Open" with "Ok" | ||||
Tags | No tags attached. | ||||
Fixed in Revision | 40743 | ||||
FPCOldBugId | |||||
FPCTarget | |||||
Attached Files |
|
|
save_as_ok_button.patch (561 bytes)
Index: packages/ide/fpmopts.inc =================================================================== --- packages/ide/fpmopts.inc (revision 40278) +++ packages/ide/fpmopts.inc (working copy) @@ -1588,7 +1588,7 @@ FileName: string; CanWrite: boolean; begin - New(D, Init('*'+ExtOf(INIFileName),dialog_saveoptions,dialog_ini_filename,fdOpenButton,hidSaveIniFile)); + New(D, Init('*'+ExtOf(INIFileName),dialog_saveoptions,dialog_ini_filename,fdOkButton,hidSaveIniFile)); D^.HelpCtx:=hcSaveAsINI; if Desktop^.ExecView(D)<>cmCancel then begin |
|
I can not reproduce it. See screenshot. |
|
|
|
Not "Save File As" dialog, but "Save Options" dialog. You definitely can reproduce it, because bug is platform irrelevant. Steps to reproduce: 1. Open fp 2. Press Alt+o and then A |
|
Indeed. confirmed. Was not clear to me though. |
|
There is no fdSaveButton equivalent? |
|
fdSaveButton was my first guess. That does not exist. It is standart file save dialog and best choice is fdOkButton TP also use "Ok" button. |
|
save_as_ok_button_v2.patch (1,092 bytes)
Index: packages/ide/fpide.pas =================================================================== --- packages/ide/fpide.pas (revision 40278) +++ packages/ide/fpide.pas (working copy) @@ -686,7 +686,7 @@ msg_errorsavingconfigfile = 'Error saving config file.'; {Save options dialog.} - dialog_saveoptions = 'Save Options'; + dialog_saveoptions = 'Save Options As'; dialog_ini_filename = 'Name of INI file'; {Window list dialog.} Index: packages/ide/fpmopts.inc =================================================================== --- packages/ide/fpmopts.inc (revision 40278) +++ packages/ide/fpmopts.inc (working copy) @@ -1588,7 +1588,7 @@ FileName: string; CanWrite: boolean; begin - New(D, Init('*'+ExtOf(INIFileName),dialog_saveoptions,dialog_ini_filename,fdOpenButton,hidSaveIniFile)); + New(D, Init('*'+ExtOf(INIFileName),dialog_saveoptions,dialog_ini_filename,fdOkButton,hidSaveIniFile)); D^.HelpCtx:=hcSaveAsINI; if Desktop^.ExecView(D)<>cmCancel then begin |
|
Thanks, applied. |
|
Thanks. |
Date Modified | Username | Field | Change |
---|---|---|---|
2018-11-10 11:58 | Marģers | New Issue | |
2018-11-10 11:58 | Marģers | File Added: save_as_ok_button.patch | |
2018-11-10 12:41 | Thaddy de Koning | Note Added: 0111886 | |
2018-11-10 12:42 | Thaddy de Koning | File Added: odok.png | |
2018-11-10 13:17 | Marģers | Note Added: 0111888 | |
2018-11-10 16:36 | Thaddy de Koning | Note Added: 0111891 | |
2018-11-10 18:50 | Bart Broersma | Note Added: 0111892 | |
2018-11-10 21:15 | Marģers | Note Added: 0111896 | |
2018-11-10 21:59 | Marģers | File Added: save_as_ok_button_v2.patch | |
2019-01-02 00:47 | Florian | Fixed in Revision | => 40743 |
2019-01-02 00:47 | Florian | Note Added: 0113079 | |
2019-01-02 00:47 | Florian | Status | new => resolved |
2019-01-02 00:47 | Florian | Fixed in Version | => 3.3.1 |
2019-01-02 00:47 | Florian | Resolution | open => fixed |
2019-01-02 00:47 | Florian | Assigned To | => Florian |
2019-01-02 01:12 | Marģers | Note Added: 0113081 | |
2019-01-02 01:12 | Marģers | Status | resolved => closed |