makerop4 should take longword parameters, not longint...
Original Reporter info from Mantis: Thaddy
-
Reporter name: Thaddy de Koning
Original Reporter info from Mantis: Thaddy
- Reporter name: Thaddy de Koning
Description:
makerop4 should take longword parameters, not longint...
Steps to reproduce:
Now:
function MAKEROP4(fore,back : longint) : DWORD;
begin
MAKEROP4:=DWORD((DWORD(back shl 8) and $FF000000) or DWORD(fore));
end;
Should be:
function MAKEROP4(fore,back : longword) : longword; inline;
begin
result:= back shl 8 and $FF000000 or fore;
end;
Additional information:
- wininc: All the surrounding functions in wininc are also subject to this issue: longint vs longword. winunits-jedi handles them correctly.
- see also: http://forum.lazarus.freepascal.org/index.php?topic=43570.msg305157#msg305157
Mantis conversion info:
- Mantis ID: 34712
- OS: windows
- Version: 3.3.1
- Fixed in version: 3.3.1
- Fixed in revision: 41269 (#d6b39276)