View Issue Details

IDProjectCategoryView StatusLast Update
0034834LazarusDatabase Componentspublic2021-03-08 09:17
ReporterLeslie Assigned ToJuha Manninen  
PrioritynormalSeverityminorReproducibilityN/A
Status resolvedResolutionfixed 
Summary0034834: TBookmarkList.CheckActive hack for TCustomBufDataset descendents
DescriptionTDoubleLinkedBufIndex.CompareBookmarks seems to be implemented now. Is this hack still necessary?
    
TagsNo tags attached.
Fixed in Revisionr64768
LazTarget-
Widgetset
Attached Files

Activities

Michael Van Canneyt

2019-01-08 04:35

administrator   ~0113249

Please explain what you mean with your question, I can't make head nor tail from it. Which hack ? Which TBookmarkList ? There is not even such a class in bufdataset or db units ?

Leslie

2019-01-08 09:56

reporter   ~0113258

Last edited: 2019-01-08 09:59

View 2 revisions

From the name "TBookmarkList" it seemed so obvious that it was a database issue, but infact it is in the DBGrid unit and the issue belongs to the Lazarus/LCL section. Is it possible to change the category assignment or do I need to post it again properly?

I need to pay more attention, so sorry for wasting your time.

Michael Van Canneyt

2019-01-08 10:13

administrator   ~0113259

Moved to lazarus, unassigned

Leslie

2019-01-08 10:21

reporter   ~0113260

Thank you!

Juha Manninen

2019-10-19 14:28

developer   ~0118692

I have the same question that Michael Van Canneyt had. What hack are you writing about?
If you know how to remove a hack then please provide a patch.
True, you should pay more attention to the quality of your bug reports.

Bart Broersma

2020-11-14 17:20

developer   ~0126935

Most likely TS means this comment and code
procedure TBookmarkList.CheckActive;
begin
<snip>
  // Note.
  //
  // Some dataset descendants do not implement CompareBookmarks, for these we
  // use MyCompareBookmarks in the hope the allocated bookmark memory is used
  // to hold some kind of record index.
  FUseCompareBookmarks := TMethod(@FDataset.CompareBookmarks).Code<>pointer(@TDataset.CompareBookmarks);

Juha Manninen

2021-03-08 09:17

developer   ~0129504

Removed. Please test.

Issue History

Date Modified Username Field Change
2019-01-08 01:54 Leslie New Issue
2019-01-08 04:30 Michael Van Canneyt Assigned To => Michael Van Canneyt
2019-01-08 04:30 Michael Van Canneyt Status new => assigned
2019-01-08 04:35 Michael Van Canneyt Note Added: 0113249
2019-01-08 04:35 Michael Van Canneyt Status assigned => feedback
2019-01-08 09:56 Leslie Note Added: 0113258
2019-01-08 09:56 Leslie Status feedback => assigned
2019-01-08 09:59 Leslie Note Edited: 0113258 View Revisions
2019-01-08 10:12 Michael Van Canneyt Project FPC => Lazarus
2019-01-08 10:12 Michael Van Canneyt LazTarget => -
2019-01-08 10:12 Michael Van Canneyt Category Database => Database Components
2019-01-08 10:12 Michael Van Canneyt Product Version 3.3.1 =>
2019-01-08 10:12 Michael Van Canneyt Assigned To Michael Van Canneyt =>
2019-01-08 10:13 Michael Van Canneyt Note Added: 0113259
2019-01-08 10:21 Leslie Note Added: 0113260
2019-01-09 13:27 Maxim Ganetsky Status assigned => new
2019-10-19 14:28 Juha Manninen Status new => feedback
2019-10-19 14:28 Juha Manninen Note Added: 0118692
2020-11-14 17:20 Bart Broersma Note Added: 0126935
2021-03-08 07:23 Juha Manninen Assigned To => Juha Manninen
2021-03-08 07:23 Juha Manninen Status feedback => assigned
2021-03-08 09:17 Juha Manninen Status assigned => resolved
2021-03-08 09:17 Juha Manninen Resolution open => fixed
2021-03-08 09:17 Juha Manninen Fixed in Revision => r64768
2021-03-08 09:17 Juha Manninen Note Added: 0129504