View Issue Details

IDProjectCategoryView StatusLast Update
0034849FPCCompilerpublic2019-01-12 15:45
ReporterJ. Gareth MoretonAssigned ToFlorian 
PrioritylowSeveritytrivialReproducibilityN/A
Status resolvedResolutionfixed 
Platformx86_64-win64OSMicrosoft WindowsOS Version10 Professional
Product Version3.3.1Product Buildx86_64-win64 
Target VersionFixed in Version3.3.1 
Summary0034849: [Patch] Internal Error number clash
DescriptionTwo procedures in compiler\x86\cpubase.pas have the same number for their internal errors, thus making it initially unclear which function failed its sanity check.
Steps To ReproduceN/A (it shouldn't actually be producible anyway!)
Additional InformationPatch changes the second number from 2017101202 to 2017101200 (following the pattern of having the date that the function was first programmed with an index appended to it, with the first digit representing a common group).
Tagscompiler, internal error, patch, x86
Fixed in Revision40849
FPCOldBugId0
FPCTarget
Attached Files
  • IntErrorClashFix.patch (390 bytes)
    Index: compiler/x86/cpubase.pas
    ===================================================================
    --- compiler/x86/cpubase.pas	(revision 40840)
    +++ compiler/x86/cpubase.pas	(working copy)
    @@ -832,7 +832,7 @@
               A_LODS,A_OUTS:
                 result:=-1;
               else
    -            internalerror(2017101202);
    +            internalerror(2017101200);
             end;
           end;
     
    

Activities

J. Gareth Moreton

2019-01-11 13:54

developer  

IntErrorClashFix.patch (390 bytes)
Index: compiler/x86/cpubase.pas
===================================================================
--- compiler/x86/cpubase.pas	(revision 40840)
+++ compiler/x86/cpubase.pas	(working copy)
@@ -832,7 +832,7 @@
           A_LODS,A_OUTS:
             result:=-1;
           else
-            internalerror(2017101202);
+            internalerror(2017101200);
         end;
       end;
 

J. Gareth Moreton

2019-01-11 14:11

developer   ~0113326

Last edited: 2019-01-11 14:11

View 2 revisions

Functions in question are "get_x86_string_op_size" and "get_x86_string_op_di_param" (of which the latter had its number changed in the supplied patch).

Florian

2019-01-12 15:45

administrator   ~0113353

Thanks, applied it modified: we normally do not use "00" and there is no grouping, so I used "04".

Issue History

Date Modified Username Field Change
2019-01-11 13:54 J. Gareth Moreton New Issue
2019-01-11 13:54 J. Gareth Moreton File Added: IntErrorClashFix.patch
2019-01-11 13:55 J. Gareth Moreton Tag Attached: compiler
2019-01-11 13:55 J. Gareth Moreton Tag Attached: internal error
2019-01-11 13:55 J. Gareth Moreton Tag Attached: patch
2019-01-11 13:55 J. Gareth Moreton Tag Attached: x86
2019-01-11 13:55 J. Gareth Moreton Priority normal => low
2019-01-11 13:55 J. Gareth Moreton Severity minor => trivial
2019-01-11 14:11 J. Gareth Moreton Note Added: 0113326
2019-01-11 14:11 J. Gareth Moreton Note Edited: 0113326 View Revisions
2019-01-12 15:45 Florian Fixed in Revision => 40849
2019-01-12 15:45 Florian Note Added: 0113353
2019-01-12 15:45 Florian Status new => resolved
2019-01-12 15:45 Florian Fixed in Version => 3.3.1
2019-01-12 15:45 Florian Resolution open => fixed
2019-01-12 15:45 Florian Assigned To => Florian
2019-01-12 15:45 Florian Target Version 3.3.1 =>