View Issue Details

IDProjectCategoryView StatusLast Update
0034917FPCPackagespublic2019-01-21 11:34
ReporterPascal RiekenbergAssigned ToMichael Van Canneyt 
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Platformi386OSWindows 10 x64OS Version1803
Product Version3.3.1Product Build40927 
Target Version3.2.0Fixed in Version3.3.1 
Summary0034917: Rev. 40927 breaks build of fcl-xml for i386-win32
DescriptionRev. 40927 breaks build of fcl-xml for i386-win32

Attached patch resolves this. Maybe another overload with UnicodeString instead of changing old one.
Additional InformationExternal command "c:/freepascal/fpc/trunk/compiler/ppc386.exe -Twin32 -FUfcl-xml\units\i386-win32\ -Fuc:\freepascal\fpc\trunk\rtl\units\i386-win32\ -Fuc:\freepascal\fpc\trunk\packages\fcl-base\units\i386-win32\ -Fuc:\fr
eepascal\fpc\trunk\packages\fcl-res\units\i386-win32\ -Fuc:\freepascal\fpc\trunk\packages\rtl-objpas\units\i386-win32\ -Fufcl-xml\src -Fifcl-xml\src -Ur -Xs -O2 -n -godwarfsets -gl -O- -di386 -dRELEASE -XX -CX -Sc -S2h
-viq fcl-xml\BuildUnit_fcl_xml.pp" failed with exit code 1. Console output:
Target OS: Win32 for i386
Compiling fcl-xml\BuildUnit_fcl_xml.pp
Compiling .\fcl-xml\src\xmlutils.pp
Compiling .\fcl-xml\src\dom.pp
Compiling .\fcl-xml\src\dtdmodel.pp
dom.pp(1283,92) Error: Call by var for arg no. 3 has to match exactly: Got "UnicodeString" expected "AnsiString"
dom.pp(1304,50) Error: Call by var for arg no. 3 has to match exactly: Got "UnicodeString" expected "AnsiString"
dom.pp(3599) Fatal: There were 2 errors compiling module, stopping
TagsNo tags attached.
Fixed in Revision40952
FPCOldBugId
FPCTarget
Attached Files
  • uriparser.pp.patch (1,101 bytes)
    Index: packages/fcl-base/src/uriparser.pp
    ===================================================================
    --- packages/fcl-base/src/uriparser.pp	(revision 40951)
    +++ packages/fcl-base/src/uriparser.pp	(working copy)
    @@ -40,8 +40,8 @@
     function ParseURI(const URI: String; Decode : Boolean = True):  TURI; overload;
     function ParseURI(const URI, DefaultProtocol: String; DefaultPort: Word; Decode : Boolean = True):  TURI; overload;
     
    -function ResolveRelativeURI(const BaseUri, RelUri: WideString;
    -  out ResultUri: WideString): Boolean; overload;
    +function ResolveRelativeURI(const BaseUri, RelUri: UnicodeString;
    +  out ResultUri: UnicodeString): Boolean; overload;
     
     function ResolveRelativeURI(const BaseUri, RelUri: AnsiString;
       out ResultUri: AnsiString): Boolean; overload;
    @@ -384,8 +384,8 @@
       ResultUri := EncodeUri(Rel);
     end;
     
    -function ResolveRelativeURI(const BaseUri, RelUri: WideString;
    -  out ResultUri: WideString): Boolean;
    +function ResolveRelativeURI(const BaseUri, RelUri: UnicodeString;
    +  out ResultUri: UnicodeString): Boolean;
     var
       rslt: AnsiString;
     begin
    
    uriparser.pp.patch (1,101 bytes)

Activities

Pascal Riekenberg

2019-01-21 06:31

reporter  

uriparser.pp.patch (1,101 bytes)
Index: packages/fcl-base/src/uriparser.pp
===================================================================
--- packages/fcl-base/src/uriparser.pp	(revision 40951)
+++ packages/fcl-base/src/uriparser.pp	(working copy)
@@ -40,8 +40,8 @@
 function ParseURI(const URI: String; Decode : Boolean = True):  TURI; overload;
 function ParseURI(const URI, DefaultProtocol: String; DefaultPort: Word; Decode : Boolean = True):  TURI; overload;
 
-function ResolveRelativeURI(const BaseUri, RelUri: WideString;
-  out ResultUri: WideString): Boolean; overload;
+function ResolveRelativeURI(const BaseUri, RelUri: UnicodeString;
+  out ResultUri: UnicodeString): Boolean; overload;
 
 function ResolveRelativeURI(const BaseUri, RelUri: AnsiString;
   out ResultUri: AnsiString): Boolean; overload;
@@ -384,8 +384,8 @@
   ResultUri := EncodeUri(Rel);
 end;
 
-function ResolveRelativeURI(const BaseUri, RelUri: WideString;
-  out ResultUri: WideString): Boolean;
+function ResolveRelativeURI(const BaseUri, RelUri: UnicodeString;
+  out ResultUri: UnicodeString): Boolean;
 var
   rslt: AnsiString;
 begin
uriparser.pp.patch (1,101 bytes)

Michael Van Canneyt

2019-01-21 09:24

administrator   ~0113545

This was discovered by our build system. I resolved it by adding an overload.

Issue History

Date Modified Username Field Change
2019-01-21 06:31 Pascal Riekenberg New Issue
2019-01-21 06:31 Pascal Riekenberg File Added: uriparser.pp.patch
2019-01-21 09:24 Michael Van Canneyt Fixed in Revision => 40952
2019-01-21 09:24 Michael Van Canneyt Note Added: 0113545
2019-01-21 09:24 Michael Van Canneyt Status new => resolved
2019-01-21 09:24 Michael Van Canneyt Fixed in Version => 3.3.1
2019-01-21 09:24 Michael Van Canneyt Resolution open => fixed
2019-01-21 09:24 Michael Van Canneyt Assigned To => Michael Van Canneyt
2019-01-21 09:24 Michael Van Canneyt Target Version => 3.2.0
2019-01-21 11:34 Pascal Riekenberg Status resolved => closed