View Issue Details

IDProjectCategoryView StatusLast Update
0035016LazarusLCLpublic2019-02-09 15:56
ReporterRyan JosephAssigned To 
PrioritynormalSeverityminorReproducibilityalways
Status newResolutionopen 
Product Version2.1 (SVN)Product Build60339 
Target VersionFixed in Version 
Summary0035016: Cocoa: TMemo WantTabs property affects focus ring
DescriptionThe WantTabs property of TMemo doesn't affect the focus ring (NSTextView.setFocusRingType) so I'm submitting this patch change to fix that.
TagsNo tags attached.
Fixed in Revision
LazTarget
WidgetsetCocoa
Attached Files
  • memofix.txt (445 bytes)
    1391c1391,1394
    <   scr.setFocusRingType(NSFocusRingTypeExterior);
    ---
    >   if not TCustomMemo(AWinControl).WantTabs then
    >     txt.setFocusRingType(NSFocusRingTypeNone)
    >   else
    >     txt.setFocusRingType(NSFocusRingTypeDefault);
    1567a1571,1574
    >   if not NewWantTabs then
    >     txt.setFocusRingType(NSFocusRingTypeNone)
    >   else
    >     txt.setFocusRingType(NSFocusRingTypeDefault);
    2079c2086,2087
    < end.
    \ No newline at end of file
    ---
    > end.
    > 
    
    memofix.txt (445 bytes)

Activities

Ryan Joseph

2019-02-05 19:30

reporter  

memofix.txt (445 bytes)
1391c1391,1394
<   scr.setFocusRingType(NSFocusRingTypeExterior);
---
>   if not TCustomMemo(AWinControl).WantTabs then
>     txt.setFocusRingType(NSFocusRingTypeNone)
>   else
>     txt.setFocusRingType(NSFocusRingTypeDefault);
1567a1571,1574
>   if not NewWantTabs then
>     txt.setFocusRingType(NSFocusRingTypeNone)
>   else
>     txt.setFocusRingType(NSFocusRingTypeDefault);
2079c2086,2087
< end.
\ No newline at end of file
---
> end.
> 
memofix.txt (445 bytes)

Alexey Tor.

2019-02-06 10:06

reporter   ~0113896

Must see- http://wiki.freepascal.org/Creating_A_Patch

Alexey Tor.

2019-02-06 21:14

reporter   ~0113908

Patch don't show WHICH FILES changed, so make proper one using "svn diff"
 from Lazarus dir.

Ryan Joseph

2019-02-09 15:56

reporter   ~0113988

I'll fix that patch later but another Lazarus user that works on Cocoa says he doesn't like my solution. I may need to figure out another way to do this.

Issue History

Date Modified Username Field Change
2019-02-05 19:30 Ryan Joseph New Issue
2019-02-05 19:30 Ryan Joseph File Added: memofix.txt
2019-02-06 10:06 Alexey Tor. Note Added: 0113896
2019-02-06 21:14 Alexey Tor. Note Added: 0113908
2019-02-09 15:56 Ryan Joseph Note Added: 0113988