View Issue Details

IDProjectCategoryView StatusLast Update
0035016LazarusLCLpublic2020-01-28 05:18
ReporterRyan Joseph Assigned ToDmitry Boyarintsev  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionno change required 
Product Version2.1 (SVN) 
Summary0035016: Cocoa: TMemo WantTabs property affects focus ring
DescriptionThe WantTabs property of TMemo doesn't affect the focus ring (NSTextView.setFocusRingType) so I'm submitting this patch change to fix that.
TagsNo tags attached.
Fixed in Revision
LazTarget-
WidgetsetCocoa
Attached Files

Activities

Ryan Joseph

2019-02-05 19:30

reporter  

memofix.txt (445 bytes)   
1391c1391,1394
<   scr.setFocusRingType(NSFocusRingTypeExterior);
---
>   if not TCustomMemo(AWinControl).WantTabs then
>     txt.setFocusRingType(NSFocusRingTypeNone)
>   else
>     txt.setFocusRingType(NSFocusRingTypeDefault);
1567a1571,1574
>   if not NewWantTabs then
>     txt.setFocusRingType(NSFocusRingTypeNone)
>   else
>     txt.setFocusRingType(NSFocusRingTypeDefault);
2079c2086,2087
< end.
\ No newline at end of file
---
> end.
> 
memofix.txt (445 bytes)   

CudaText man

2019-02-06 10:06

reporter   ~0113896

Must see- http://wiki.freepascal.org/Creating_A_Patch

CudaText man

2019-02-06 21:14

reporter   ~0113908

Patch don't show WHICH FILES changed, so make proper one using "svn diff"
 from Lazarus dir.

Ryan Joseph

2019-02-09 15:56

reporter   ~0113988

I'll fix that patch later but another Lazarus user that works on Cocoa says he doesn't like my solution. I may need to figure out another way to do this.

Dmitry Boyarintsev

2020-01-28 05:18

developer   ~0120782

currently, if memo is set to be borderless, it will not get a focus ring

Issue History

Date Modified Username Field Change
2019-02-05 19:30 Ryan Joseph New Issue
2019-02-05 19:30 Ryan Joseph File Added: memofix.txt
2019-02-06 10:06 CudaText man Note Added: 0113896
2019-02-06 21:14 CudaText man Note Added: 0113908
2019-02-09 15:56 Ryan Joseph Note Added: 0113988
2020-01-28 05:18 Dmitry Boyarintsev Assigned To => Dmitry Boyarintsev
2020-01-28 05:18 Dmitry Boyarintsev Status new => resolved
2020-01-28 05:18 Dmitry Boyarintsev Resolution open => no change required
2020-01-28 05:18 Dmitry Boyarintsev LazTarget => -
2020-01-28 05:18 Dmitry Boyarintsev Widgetset Cocoa => Cocoa
2020-01-28 05:18 Dmitry Boyarintsev Note Added: 0120782