View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0035016 | Lazarus | LCL | public | 2019-02-05 19:30 | 2020-01-28 05:18 |
Reporter | Ryan Joseph | Assigned To | Dmitry Boyarintsev | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | resolved | Resolution | no change required | ||
Product Version | 2.1 (SVN) | ||||
Summary | 0035016: Cocoa: TMemo WantTabs property affects focus ring | ||||
Description | The WantTabs property of TMemo doesn't affect the focus ring (NSTextView.setFocusRingType) so I'm submitting this patch change to fix that. | ||||
Tags | No tags attached. | ||||
Fixed in Revision | |||||
LazTarget | - | ||||
Widgetset | Cocoa | ||||
Attached Files |
|
|
memofix.txt (445 bytes)
1391c1391,1394 < scr.setFocusRingType(NSFocusRingTypeExterior); --- > if not TCustomMemo(AWinControl).WantTabs then > txt.setFocusRingType(NSFocusRingTypeNone) > else > txt.setFocusRingType(NSFocusRingTypeDefault); 1567a1571,1574 > if not NewWantTabs then > txt.setFocusRingType(NSFocusRingTypeNone) > else > txt.setFocusRingType(NSFocusRingTypeDefault); 2079c2086,2087 < end. \ No newline at end of file --- > end. > |
|
Must see- http://wiki.freepascal.org/Creating_A_Patch |
|
Patch don't show WHICH FILES changed, so make proper one using "svn diff" from Lazarus dir. |
|
I'll fix that patch later but another Lazarus user that works on Cocoa says he doesn't like my solution. I may need to figure out another way to do this. |
|
currently, if memo is set to be borderless, it will not get a focus ring |
Date Modified | Username | Field | Change |
---|---|---|---|
2019-02-05 19:30 | Ryan Joseph | New Issue | |
2019-02-05 19:30 | Ryan Joseph | File Added: memofix.txt | |
2019-02-06 10:06 | CudaText man | Note Added: 0113896 | |
2019-02-06 21:14 | CudaText man | Note Added: 0113908 | |
2019-02-09 15:56 | Ryan Joseph | Note Added: 0113988 | |
2020-01-28 05:18 | Dmitry Boyarintsev | Assigned To | => Dmitry Boyarintsev |
2020-01-28 05:18 | Dmitry Boyarintsev | Status | new => resolved |
2020-01-28 05:18 | Dmitry Boyarintsev | Resolution | open => no change required |
2020-01-28 05:18 | Dmitry Boyarintsev | LazTarget | => - |
2020-01-28 05:18 | Dmitry Boyarintsev | Widgetset | Cocoa => Cocoa |
2020-01-28 05:18 | Dmitry Boyarintsev | Note Added: 0120782 |