All Projects FPC fpcprojects fpprofilerfpGUI Lazarus Packages PatchesLazarus CCR Mantis pas2js

View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0035212LazarusTAChartpublic2019-03-09 21:262019-03-10 00:01
ReporterMarcin WiazowskiAssigned Towp 
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version2.1 (SVN)Product Build60636 
Target Version2.2Fixed in Version 
Summary0035212: TAChart: trivial labeling issue in TFieldSeries
DescriptionLet's assume that TFieldSeries uses a data source having YCount = 6:
- Y0 is a coordinate of the data point,
- Y1 is a height of the vector (it's not a "normal" data point),
- Y2 .. Y5 are not used.

But marks for all Y0 .. Y5 coordinates are drawn, which is improper. The attached patch is a most trivial patch that can exist, and solves the problem.

As I checked in the code, all the other existing series seem to handle the described case properly.
TagsNo tags attached.
Fixed in Revision60637
LazTarget2.2
WidgetsetWin32/Win64
Attached Files
  • Reproduce.zip (2,377 bytes)
  • Reproduce.png (8,931 bytes)
    Reproduce.png (8,931 bytes)
  • patch.diff (413 bytes) 
    Index: components/tachart/tamultiseries.pas
===================================================================
--- components/tachart/tamultiseries.pas	(revision 60636)
+++ components/tachart/tamultiseries.pas	(working copy)
@@ -1833,7 +1833,7 @@
           DrawVector(ADrawer, p1, p2, lPen);
         end;
     end;
-    DrawLabels(ADrawer);
+    DrawLabels(ADrawer, 0);
   finally
     lPen.Free;
   end;
    patch.diff (413 bytes)

Activities

Marcin Wiazowski

2019-03-09 21:26

reporter  

Reproduce.zip (2,377 bytes)

Marcin Wiazowski

2019-03-09 21:27

reporter  

Reproduce.png (8,931 bytes)
Reproduce.png (8,931 bytes)

Marcin Wiazowski

2019-03-09 21:27

reporter  

patch.diff (413 bytes) 
Index: components/tachart/tamultiseries.pas
===================================================================
--- components/tachart/tamultiseries.pas	(revision 60636)
+++ components/tachart/tamultiseries.pas	(working copy)
@@ -1833,7 +1833,7 @@
           DrawVector(ADrawer, p1, p2, lPen);
         end;
     end;
-    DrawLabels(ADrawer);
+    DrawLabels(ADrawer, 0);
   finally
     lPen.Free;
   end;
patch.diff (413 bytes)

wp

2019-03-09 22:51

developer   ~0114747

Applied, thank you.

Marcin Wiazowski

2019-03-10 00:01

reporter   ~0114752

Thanks!

Issue History

Date Modified Username Field Change
2019-03-09 21:26 Marcin Wiazowski New Issue
2019-03-09 21:26 Marcin Wiazowski File Added: Reproduce.zip
2019-03-09 21:27 Marcin Wiazowski File Added: Reproduce.png
2019-03-09 21:27 Marcin Wiazowski File Added: patch.diff
2019-03-09 22:51 wp Fixed in Revision => 60637
2019-03-09 22:51 wp LazTarget => 2.2
2019-03-09 22:51 wp Note Added: 0114747
2019-03-09 22:51 wp Status new => resolved
2019-03-09 22:51 wp Resolution open => fixed
2019-03-09 22:51 wp Assigned To => wp
2019-03-09 22:51 wp Target Version => 2.2
2019-03-10 00:01 Marcin Wiazowski Note Added: 0114752
2019-03-10 00:01 Marcin Wiazowski Status resolved => closed