|
|
popupmenu.patch (999 bytes) |
|
|
Applied, thanks. |
|
|
I'm afraid this bugfix is incorrect. [u][b]Summary:[/b][/u] If you have a TPopupMenu with a TMenuItem (parent) with a [b]sub[/b] (child) TMenuItem, when you simply [b]hover[/b] on the parent TMenuItem: Expected behaviour: The Submenu Item should open. Actual behaviour: The Submenu Item opens, [b]AND[/b] it triggers the onClick event of the parent TMenuItem (if one exists) (if AutoCheck is false) [b]or[/b] toggles the 'checked' status of the parent TMenuItem (if AutoCheck is true) [u][b]Steps to reproduce (if AutoCheck is set to true):[/b][/u] 1. Create a TPopupMenu 2. Inside it: Create a Menu Item (parent) Set Checked := true; Set AutoCheck := true; (or see below if you set AutoCheck to false) 3. Inside that menu item: Create a **sub** Menu item (child) to the right. 4. Run the program, and **hover** over the parent menu. Problem: It toggles the 'checked' status of the parent MenuItem. [u][b]Alternative (if AutoCheck set to false):[/b][/u] 1. Create a TPopupMenu 2. Inside it: Create a Menu Item (parent) Set Checked := true; Set AutoCheck := false; 3. Inside that menu item: Create a **sub** Menu item (child) to the right. 4. Create an **OnClick** event handler for the parent Menu Item: [code=pascal]procedure TForm1.MenuItem1Click(Sender: TObject); begin showmessage('Clicked!'); end;[/code] 5. Run the program, and **hover** over the parent menu. Problem: It triggers the OnClick event. I'm running Lazarus 2.0.6 on Windows 10. Popup menu bug.jpg (16,380 bytes) |
|
|
Benito, the patch created a regression. Please see the related issue. |
|
|
I hope you reverted that patch because that it total BS. |
|
|
I reverted r60679. I am detaching myself. Somebody with Windows as a development OS, please continue with this. |
|
|
There is no need to change it, it works correctly as it is/was. And why would you want the OnClick event of the parent to fire when merely opening a submenu ? I am only going by what the poster left for everyone else to read. If that was me leaving that patch and it got applied I could be grinning, but I am not that kind of a person. |
|
|
> And why would you want the OnClick event of the parent to fire when merely opening a submenu ? That is just how menus work You can try it with a main menu rather than a popup menu, or read about it: https://stackoverflow.com/a/14076860/1501222 |
|
|
that isn't how it works here.. Please incorporate that in your own code if that is what you want. I don't want the parent OnClick to fire in my code when I merely open a sub menu. the submenu is there to allow you to make the choice from the user's stand point not automatically fire off a parent onclick for which is has a different purpose when the sub's open. You can elect to have a parent menu have different action for it's own onclick over a submenu... all of what you need can be done in user code, its not a block on your end and what you are suggesting will then limit the flexibility of the menus if not introduce bugs for other code.. The property request would be to have a property that would optionally trigger an event in the parent of a submenu, but not the onclick. This would have to be a specific event to this task.. For example OnChildMenuOpen. etc If you notice submenu's have their own onclicks, there is a reason for that |
|
|
@Jamie: > I don't want the parent OnClick to fire in my code when I merely open a sub menu. This is how it works in Delphi 7 (the only version I can test). Given this popup menu Item1->Sub Item 2 When the popupmenu pops up and I click/traverse Item1, it opens Sub (as expected) and it fires Item1's OnClick event. |
- Anonymous
