View Issue Details

IDProjectCategoryView StatusLast Update
0035280FPCDatabasepublic2019-03-27 08:11
ReporterPascal RiekenbergAssigned ToMichael Van Canneyt 
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Platformi386OSWindows 10 x64OS Version1809
Product Version3.3.1Product Build41795 
Target Version3.2.0Fixed in Version3.3.1 
Summary0035280: r41795 breaks build of fcl-db
Descriptionchange to collect.inc breaks build of fcl-db.
Additional InformationTarget OS: Win32 for i386
Compiling fcl-db\BuildUnit_fcl_db.pp
Compiling .\fcl-db\src\base\dbconst.pas
Writing Resource String Table file: dbconst.rsj
Compiling .\fcl-db\src\base\db.pas
dsparams.inc(431,58) Error: Wrong number of parameters specified for call to "Move"
collect.inc(437,23) Error: Found declaration: Move(const LongInt;const LongInt);
dsparams.inc(457,58) Error: Wrong number of parameters specified for call to "Move"
collect.inc(437,23) Error: Found declaration: Move(const LongInt;const LongInt);
db.pas(2718) Fatal: There were 4 errors compiling module, stopping
Fatal: Compilation aborted
TagsNo tags attached.
Fixed in Revisionr41796
FPCOldBugId
FPCTarget
Attached Files
  • dsparams.inc.patch (2,045 bytes)
    Index: packages/fcl-db/src/base/dsparams.inc
    ===================================================================
    --- packages/fcl-db/src/base/dsparams.inc	(revision 41795)
    +++ packages/fcl-db/src/base/dsparams.inc	(working copy)
    @@ -428,7 +428,7 @@
         for i:=0 to High(ParamPart) do
         begin
           CopyLen:=ParamPart[i].Start-BufIndex;
    -      Move(SQL[BufIndex],NewQuery[NewQueryIndex],CopyLen);
    +      System.Move(SQL[BufIndex],NewQuery[NewQueryIndex],CopyLen);
           Inc(NewQueryIndex,CopyLen);
           case ParameterStyle of
             psInterbase : begin
    @@ -454,7 +454,7 @@
         end;
         CopyLen:=Length(SQL)+1-BufIndex;
         if CopyLen > 0 then
    -      Move(SQL[BufIndex],NewQuery[NewQueryIndex],CopyLen);
    +      System.Move(SQL[BufIndex],NewQuery[NewQueryIndex],CopyLen);
       end
       else
         NewQuery:=SQL;
    @@ -600,7 +600,7 @@
         SetLength(Result, (VarArrayHighBound(FValue, 1) + 1) div SizeOf(Char));
         P := VarArrayLock(FValue);
         try
    -      Move(P^, Result[1], Length(Result) * SizeOf(Char));
    +      System.Move(P^, Result[1], Length(Result) * SizeOf(Char));
         finally
           VarArrayUnlock(FValue);
         end;
    @@ -1045,7 +1045,7 @@
           ws := GetAsWideString;
           l := Length(ws);
           if l > 0 then
    -        Move(ws[1], Buffer, Succ(l)*2)
    +        System.Move(ws[1], Buffer, Succ(l)*2)
           else
             PWideChar(Buffer)^ := #0
         end;
    @@ -1058,7 +1058,7 @@
         ftOraClob  :
           begin
           S:=GetAsString;
    -      Move(PChar(S)^, Buffer^, Length(S));
    +      System.Move(PChar(S)^, Buffer^, Length(S));
           end;
         ftBytes, ftVarBytes:
           begin
    @@ -1066,7 +1066,7 @@
             begin
             P:=VarArrayLock(FValue);
             try
    -          Move(P^, Buffer^, VarArrayHighBound(FValue, 1) + 1);
    +          System.Move(P^, Buffer^, VarArrayHighBound(FValue, 1) + 1);
             finally
               VarArrayUnlock(FValue);
             end;
    @@ -1155,7 +1155,7 @@
     
     begin
       SetLength(Temp,ASize);
    -  Move(Buffer^,Temp[0],ASize);
    +  System.Move(Buffer^,Temp[0],ASize);
       AsBlob:=Temp;
     end;
     
    
    dsparams.inc.patch (2,045 bytes)
  • laz.virtualtrees.pas.patch (1,548 bytes)
    Index: components/virtualtreeview/laz.virtualtrees.pas
    ===================================================================
    --- components/virtualtreeview/laz.virtualtrees.pas	(revision 60770)
    +++ components/virtualtreeview/laz.virtualtrees.pas	(working copy)
    @@ -8240,12 +8240,12 @@
         if OldPosition < Position then
         begin
           // column will be moved up so move down other entries
    -      Move(FPositionToIndex[OldPosition + 1], FPositionToIndex[OldPosition], (Position - OldPosition) * SizeOf(Cardinal));
    +      System.Move(FPositionToIndex[OldPosition + 1], FPositionToIndex[OldPosition], (Position - OldPosition) * SizeOf(Cardinal));
         end
         else
         begin
           // column will be moved down so move up other entries
    -      Move(FPositionToIndex[Position], FPositionToIndex[Position + 1], (OldPosition - Position) * SizeOf(Cardinal));
    +      System.Move(FPositionToIndex[Position], FPositionToIndex[Position + 1], (OldPosition - Position) * SizeOf(Cardinal));
         end;
         FPositionToIndex[Position] := Column.Index;
       end;
    @@ -8490,7 +8490,7 @@
           begin
             // Index found. Move all higher entries one step down and remove the last entry.
             if I < Upper then
    -          Move(FPositionToIndex[I + 1], FPositionToIndex[I], (Upper - I) * SizeOf(TColumnIndex));
    +          System.Move(FPositionToIndex[I + 1], FPositionToIndex[I], (Upper - I) * SizeOf(TColumnIndex));
           end;
           // Decrease all indices, which are greater than the index to be deleted.
           if FPositionToIndex[I] > OldIndex then
    

Relationships

related to 0035282 closedMichael Van Canneyt Packages FPC r41795 breaks build of laz.virtualtrees.pas 

Activities

Pascal Riekenberg

2019-03-26 10:52

reporter  

dsparams.inc.patch (2,045 bytes)
Index: packages/fcl-db/src/base/dsparams.inc
===================================================================
--- packages/fcl-db/src/base/dsparams.inc	(revision 41795)
+++ packages/fcl-db/src/base/dsparams.inc	(working copy)
@@ -428,7 +428,7 @@
     for i:=0 to High(ParamPart) do
     begin
       CopyLen:=ParamPart[i].Start-BufIndex;
-      Move(SQL[BufIndex],NewQuery[NewQueryIndex],CopyLen);
+      System.Move(SQL[BufIndex],NewQuery[NewQueryIndex],CopyLen);
       Inc(NewQueryIndex,CopyLen);
       case ParameterStyle of
         psInterbase : begin
@@ -454,7 +454,7 @@
     end;
     CopyLen:=Length(SQL)+1-BufIndex;
     if CopyLen > 0 then
-      Move(SQL[BufIndex],NewQuery[NewQueryIndex],CopyLen);
+      System.Move(SQL[BufIndex],NewQuery[NewQueryIndex],CopyLen);
   end
   else
     NewQuery:=SQL;
@@ -600,7 +600,7 @@
     SetLength(Result, (VarArrayHighBound(FValue, 1) + 1) div SizeOf(Char));
     P := VarArrayLock(FValue);
     try
-      Move(P^, Result[1], Length(Result) * SizeOf(Char));
+      System.Move(P^, Result[1], Length(Result) * SizeOf(Char));
     finally
       VarArrayUnlock(FValue);
     end;
@@ -1045,7 +1045,7 @@
       ws := GetAsWideString;
       l := Length(ws);
       if l > 0 then
-        Move(ws[1], Buffer, Succ(l)*2)
+        System.Move(ws[1], Buffer, Succ(l)*2)
       else
         PWideChar(Buffer)^ := #0
     end;
@@ -1058,7 +1058,7 @@
     ftOraClob  :
       begin
       S:=GetAsString;
-      Move(PChar(S)^, Buffer^, Length(S));
+      System.Move(PChar(S)^, Buffer^, Length(S));
       end;
     ftBytes, ftVarBytes:
       begin
@@ -1066,7 +1066,7 @@
         begin
         P:=VarArrayLock(FValue);
         try
-          Move(P^, Buffer^, VarArrayHighBound(FValue, 1) + 1);
+          System.Move(P^, Buffer^, VarArrayHighBound(FValue, 1) + 1);
         finally
           VarArrayUnlock(FValue);
         end;
@@ -1155,7 +1155,7 @@
 
 begin
   SetLength(Temp,ASize);
-  Move(Buffer^,Temp[0],ASize);
+  System.Move(Buffer^,Temp[0],ASize);
   AsBlob:=Temp;
 end;
 
dsparams.inc.patch (2,045 bytes)

Pascal Riekenberg

2019-03-26 10:52

reporter   ~0115051

Use attached patch.

Pascal Riekenberg

2019-03-26 11:52

reporter  

laz.virtualtrees.pas.patch (1,548 bytes)
Index: components/virtualtreeview/laz.virtualtrees.pas
===================================================================
--- components/virtualtreeview/laz.virtualtrees.pas	(revision 60770)
+++ components/virtualtreeview/laz.virtualtrees.pas	(working copy)
@@ -8240,12 +8240,12 @@
     if OldPosition < Position then
     begin
       // column will be moved up so move down other entries
-      Move(FPositionToIndex[OldPosition + 1], FPositionToIndex[OldPosition], (Position - OldPosition) * SizeOf(Cardinal));
+      System.Move(FPositionToIndex[OldPosition + 1], FPositionToIndex[OldPosition], (Position - OldPosition) * SizeOf(Cardinal));
     end
     else
     begin
       // column will be moved down so move up other entries
-      Move(FPositionToIndex[Position], FPositionToIndex[Position + 1], (OldPosition - Position) * SizeOf(Cardinal));
+      System.Move(FPositionToIndex[Position], FPositionToIndex[Position + 1], (OldPosition - Position) * SizeOf(Cardinal));
     end;
     FPositionToIndex[Position] := Column.Index;
   end;
@@ -8490,7 +8490,7 @@
       begin
         // Index found. Move all higher entries one step down and remove the last entry.
         if I < Upper then
-          Move(FPositionToIndex[I + 1], FPositionToIndex[I], (Upper - I) * SizeOf(TColumnIndex));
+          System.Move(FPositionToIndex[I + 1], FPositionToIndex[I], (Upper - I) * SizeOf(TColumnIndex));
       end;
       // Decrease all indices, which are greater than the index to be deleted.
       if FPositionToIndex[I] > OldIndex then

Pascal Riekenberg

2019-03-26 11:53

reporter   ~0115052

Please also update laz.virtualtrees.pas. See attached patch.

Pascal Riekenberg

2019-03-26 12:56

reporter   ~0115053

Last edited: 2019-03-26 15:24

View 3 revisions

Created new issue (0035282) for laz.virtualtrees.pas. So ignore this patch here.

Cyrax

2019-03-26 16:13

reporter   ~0115058

Related to bug report https://bugs.freepascal.org/view.php?id=32673

Michael Van Canneyt

2019-03-26 22:10

administrator   ~0115065

Fixed by Marcus

Issue History

Date Modified Username Field Change
2019-03-26 10:17 Pascal Riekenberg New Issue
2019-03-26 10:52 Pascal Riekenberg File Added: dsparams.inc.patch
2019-03-26 10:52 Pascal Riekenberg Note Added: 0115051
2019-03-26 11:52 Pascal Riekenberg File Added: laz.virtualtrees.pas.patch
2019-03-26 11:53 Pascal Riekenberg Note Added: 0115052
2019-03-26 12:56 Pascal Riekenberg Note Added: 0115053
2019-03-26 12:56 Pascal Riekenberg Note Edited: 0115053 View Revisions
2019-03-26 15:24 Pascal Riekenberg Note Edited: 0115053 View Revisions
2019-03-26 15:43 Juha Manninen Relationship added related to 0035282
2019-03-26 16:13 Cyrax Note Added: 0115058
2019-03-26 22:10 Michael Van Canneyt Fixed in Revision => r41796
2019-03-26 22:10 Michael Van Canneyt Note Added: 0115065
2019-03-26 22:10 Michael Van Canneyt Status new => resolved
2019-03-26 22:10 Michael Van Canneyt Fixed in Version => 3.3.1
2019-03-26 22:10 Michael Van Canneyt Resolution open => fixed
2019-03-26 22:10 Michael Van Canneyt Assigned To => Michael Van Canneyt
2019-03-26 22:10 Michael Van Canneyt Target Version => 3.2.0
2019-03-27 08:11 Pascal Riekenberg Status resolved => closed