View Issue Details

IDProjectCategoryView StatusLast Update
0035813FPCFCLpublic2019-07-08 12:24
ReporterMaciej IzakAssigned ToMichael Van Canneyt 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version3.3.1Product Build 
Target VersionFixed in Version3.3.1 
Summary0035813: [patch] Impossible multiply usage of Load for TVersionInfo
DescriptionFix for multiply usage of Load for TVersionInfo (for now is impossible to use the same instance of TVersionInfo , the clear operation between many "Load" is buggy). Patch attached.
TagsNo tags attached.
Fixed in Revision42343
FPCOldBugId
FPCTarget3.2.0
Attached Files
  • fileinfo.pp.patch (436 bytes)
    Index: packages/fcl-base/src/fileinfo.pp
    ===================================================================
    --- packages/fcl-base/src/fileinfo.pp	(revision 42342)
    +++ packages/fcl-base/src/fileinfo.pp	(working copy)
    @@ -172,7 +172,10 @@
     
     begin
       if Assigned(FResources) then
    -    FreeAndNil(FResources)
    +    begin
    +      FreeAndNil(FResources);
    +      FVersionInfo := nil;
    +    end
       else
         FreeAndNil(FVersionInfo);
     end;
    
    fileinfo.pp.patch (436 bytes)

Activities

Maciej Izak

2019-07-08 12:14

reporter  

fileinfo.pp.patch (436 bytes)
Index: packages/fcl-base/src/fileinfo.pp
===================================================================
--- packages/fcl-base/src/fileinfo.pp	(revision 42342)
+++ packages/fcl-base/src/fileinfo.pp	(working copy)
@@ -172,7 +172,10 @@
 
 begin
   if Assigned(FResources) then
-    FreeAndNil(FResources)
+    begin
+      FreeAndNil(FResources);
+      FVersionInfo := nil;
+    end
   else
     FreeAndNil(FVersionInfo);
 end;
fileinfo.pp.patch (436 bytes)

Michael Van Canneyt

2019-07-08 12:24

administrator   ~0117113

Checked & applied, thank you very much !

Issue History

Date Modified Username Field Change
2019-07-08 12:14 Maciej Izak New Issue
2019-07-08 12:14 Maciej Izak File Added: fileinfo.pp.patch
2019-07-08 12:24 Michael Van Canneyt Assigned To => Michael Van Canneyt
2019-07-08 12:24 Michael Van Canneyt Status new => resolved
2019-07-08 12:24 Michael Van Canneyt Resolution open => fixed
2019-07-08 12:24 Michael Van Canneyt Fixed in Version => 3.3.1
2019-07-08 12:24 Michael Van Canneyt Fixed in Revision => 42343
2019-07-08 12:24 Michael Van Canneyt FPCTarget => 3.2.0
2019-07-08 12:24 Michael Van Canneyt Note Added: 0117113