View Issue Details

IDProjectCategoryView StatusLast Update
0035904LazarusIDEpublic2019-07-29 21:47
ReporterZoran VučenovićAssigned ToDmitry Boyarintsev 
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version2.0.3 (SVN)Product Build61639 
Target VersionFixed in Version 
Summary0035904: Fixes branch compilation broken
DescriptionLazarus compilation fails since rev. 61639
Tested on Windows and Linux 64 bit

Compile package LCLBase 2.0.3: Exit code 1, Errors: 1
customupdown.inc(467,10) Error: Identifier not found "FUseWS"
TagsNo tags attached.
Fixed in Revision61642
LazTarget-
Widgetset
Attached Files

Relationships

has duplicate 0035900 closedDmitry Boyarintsev customupdown.inc(467,10) Error: Identifier not found "FUseWS" 

Activities

Karl-Michael Schindler

2019-07-29 12:23

reporter   ~0117475

same for darwin cocoa and carbon.

Karl-Michael Schindler

2019-07-29 14:16

reporter   ~0117483

Adding the declaration

FUseWS: Boolean;

after line 1890 in comctrls.pp fixes this error, but building then fails with:

...
Compiling cocoawscomctrls.pas
cocoawscomctrls.pas(220,21) Error: There is no method in an ancestor class to be overridden: "class SetIncrement(const TCustomUpDown;Double);"
cocoawscomctrls.pas(221,21) Error: There is no method in an ancestor class to be overridden: "class SetMaxPosition(const TCustomUpDown;Double);"
cocoawscomctrls.pas(222,21) Error: There is no method in an ancestor class to be overridden: "class SetMinPosition(const TCustomUpDown;Double);"
cocoawscomctrls.pas(223,21) Error: There is no method in an ancestor class to be overridden: "class SetPosition(const TCustomUpDown;Double);"
cocoawscomctrls.pas(224,21) Error: There is no method in an ancestor class to be overridden: "class SetWrap(const TCustomUpDown;Boolean);"
cocoawscomctrls.pas(270,1) Fatal: There were 5 errors compiling module, stopping
Fatal: Compilation aborted
...

This can be fixed with commit 60965 to lcl/widgetset/wscomctrls.pp.

Then "make bigide" builds again. However, I have not really tested it.

Applying the complete commit of 60966 to with the declaration of "procedure InitializeWnd; override;" results in this error:

...
comctrls.pp(1912,12) Error: Forward declaration not solved "InitializeWnd;"
comctrls.pp(4189) Fatal: There were 1 errors compiling module, stopping
Fatal: Compilation aborted
...

which can be fixed by applying the complete commit, which in turn requires commit 60964 on lcl/widgetset/wslclclasses.pp

In summary, applying the commits 60964, 60965, and 60966 fixes building of carbon, cocoa, Qt4, Qt5 and GTK2 lazarus on macOS. However, it got a bit messy here. So, it would be better that someone confirms this.

Dmitry Boyarintsev

2019-07-29 14:59

developer   ~0117487

please test and close if ok

Karl-Michael Schindler

2019-07-29 15:17

reporter   ~0117489

I can confirm the fix for macOS.

Zoran Vučenović

2019-07-29 21:47

developer   ~0117492

Okay, thank you, closing.

Issue History

Date Modified Username Field Change
2019-07-29 11:46 Zoran Vučenović New Issue
2019-07-29 12:23 Karl-Michael Schindler Note Added: 0117475
2019-07-29 14:16 Karl-Michael Schindler Note Added: 0117483
2019-07-29 14:59 Dmitry Boyarintsev Assigned To => Dmitry Boyarintsev
2019-07-29 14:59 Dmitry Boyarintsev Status new => resolved
2019-07-29 14:59 Dmitry Boyarintsev Resolution open => fixed
2019-07-29 14:59 Dmitry Boyarintsev Fixed in Revision => 61642
2019-07-29 14:59 Dmitry Boyarintsev LazTarget => -
2019-07-29 14:59 Dmitry Boyarintsev Note Added: 0117487
2019-07-29 15:00 Dmitry Boyarintsev Relationship added has duplicate 0035900
2019-07-29 15:17 Karl-Michael Schindler Note Added: 0117489
2019-07-29 21:47 Zoran Vučenović Status resolved => closed
2019-07-29 21:47 Zoran Vučenović Note Added: 0117492