View Issue Details

IDProjectCategoryView StatusLast Update
0036064FPCRTLpublic2019-09-12 09:50
ReporterMarcel KilgusAssigned ToMarco van de Voort 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Platformx64OSWindowsOS Versionany
Product Version3.0.4Product Build 
Target VersionFixed in Version3.3.1 
Summary0036064: TPrintDlg WIN64 structure alignment
DescriptionThe commdlg.h structures are weird in that they are byte aligned on WIN32 and natively aligned on WIN64:

  #if !defined(_WIN64)
  #include <pshpack1.h> /* Assume byte packing throughout */
  #endif

Currently the TPrintDlg structure located in rtl/win/wininc/struct.inc only works in WIN32, it could be fixed like this:

  {$IFDEF WIN64}
    TPRINTDLG = record
  {$ELSE}
    TPRINTDLG = packed record
  {$ENDIF}

I didn't find any other structure that needed this treatment but only really had a very brief glance.
TagsNo tags attached.
Fixed in Revision42976
FPCOldBugId
FPCTarget-
Attached Files

Activities

Marco van de Voort

2019-09-12 09:50

manager   ~0118049

thanks., fixed in trunk svn

Issue History

Date Modified Username Field Change
2019-09-11 13:35 Marcel Kilgus New Issue
2019-09-12 09:50 Marco van de Voort Assigned To => Marco van de Voort
2019-09-12 09:50 Marco van de Voort Status new => resolved
2019-09-12 09:50 Marco van de Voort Resolution open => fixed
2019-09-12 09:50 Marco van de Voort Fixed in Version => 3.3.1
2019-09-12 09:50 Marco van de Voort Fixed in Revision => 42976
2019-09-12 09:50 Marco van de Voort FPCTarget => -
2019-09-12 09:50 Marco van de Voort Note Added: 0118049