View Issue Details

IDProjectCategoryView StatusLast Update
0036526FPCCompilerpublic2020-04-15 13:34
ReporterCyrax Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Status newResolutionopen 
PlatformLinux x86_64OSArch 
Product Version3.3.1 
Summary0036526: [patch] Quote path - which is passed to Windres or alike program - properly so it can run successfully.
DescriptionThis will allow generating proper resource binary files on paths which will contain spaces, at both Linux and Windows targets.
Tagspatch
Fixed in Revision
FPCOldBugId
FPCTarget
Attached Files

Activities

Cyrax

2020-01-06 17:05

reporter  

comprsrc.pas.diff (347 bytes)   
diff --git a/compiler/comprsrc.pas b/compiler/comprsrc.pas
index b5638b088f..514ae4c43c 100644
--- a/compiler/comprsrc.pas
+++ b/compiler/comprsrc.pas
@@ -259,6 +259,7 @@ var
     for I:=1 to Length(Result) do
     if Result[I] in AllowDirectorySeparators then
       Result[i]:='/';
+    Result:=maybequoted(Result);
   end;
 
 begin
-- 
2.24.1

comprsrc.pas.diff (347 bytes)   

Cyrax

2020-04-15 13:34

reporter   ~0122158

In this thread https://forum.lazarus.freepascal.org/index.php/topic,49320.0.html a user is reporting an encounter at this bug.

Issue History

Date Modified Username Field Change
2020-01-06 17:05 Cyrax New Issue
2020-01-06 17:05 Cyrax File Added: comprsrc.pas.diff
2020-01-06 17:05 Cyrax Tag Attached: patch
2020-04-15 13:34 Cyrax Note Added: 0122158