View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0036643 | FPC | Packages | public | 2020-01-31 11:16 | 2020-02-04 12:41 |
| Reporter | Petr-K | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | sometimes |
| Status | new | Resolution | open | ||
| Product Version | 3.3.1 | ||||
| Summary | 0036643: Range check error in packages/paszlib/src/trees.pas | ||||
| Description | If compiled with range checking in function send_tree() construction nextlen := tree[n+1].dl.Len; The same construction in function scan_tree() was wrapped with {$push}{$R-} ... {$pop} by florian in rev 23890. Similar patch is included. | ||||
| Tags | No tags attached. | ||||
| Fixed in Revision | |||||
| FPCOldBugId | |||||
| FPCTarget | |||||
| Attached Files |
| ||||
|
|
trees.patch (374 bytes)
Index: trees.pas
===================================================================
--- trees.pas (revision 39611)
+++ trees.pas (working copy)
@@ -1553,7 +1553,9 @@
for n := 0 to max_code do
begin
curlen := nextlen;
+{$push}{$R-}
nextlen := tree[n+1].dl.Len;
+{$pop}
inc(count);
if (count < max_count) and (curlen = nextlen) then
continue
|
|
|
This might be an ongoing issue with a couple of my recent optimisation improvements on i386 and x86_64. It seems to have messed up the range checking a bit, so I'll have to see what's going on. |
|
|
nextlen is integer, dl.len is word, no mode, so that seems definitely a range violation. |
|
|
Does the issue still exist? |
|
|
(Range check issue at 0036630 has been resolved - uncertain if this is related) |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2020-01-31 11:16 | Petr-K | New Issue | |
| 2020-01-31 11:16 | Petr-K | File Added: trees.patch | |
| 2020-01-31 12:14 | J. Gareth Moreton | Note Added: 0120823 | |
| 2020-02-04 10:54 | Marco van de Voort | Note Added: 0120878 | |
| 2020-02-04 12:07 | J. Gareth Moreton | Note Added: 0120879 | |
| 2020-02-04 12:41 | J. Gareth Moreton | Note Added: 0120880 |
