View Issue Details

IDProjectCategoryView StatusLast Update
0036789LazarusLCLpublic2020-03-13 02:35
ReporterOndrej Pokorny Assigned ToOndrej Pokorny  
PrioritynormalSeverityminorReproducibilityhave not tried
Status assignedResolutionopen 
Summary0036789: MenuItem destructor optimization
DescriptionMake Delete a function that returns the deleted TMenuItem so that
MenuItem.Delete(ItemIndex).Free;
can be used instead of
MenuItem.Items[ItemIndex].Free;

The former is faster because TMenuItem.Destroy doesn't need to search through the parent's list.
Additional InformationSee r62738 that reverted this new optimization.
TagsNo tags attached.
Fixed in Revision
LazTarget
Widgetset
Attached Files

Relationships

related to 0036746 resolvedOndrej Pokorny Patches Removing sub menu causes crash 

Activities

jamie philbrook

2020-03-13 02:35

reporter   ~0121577

I don't see the change, its still the PROCEDURE DELETE, not a function ?

Who's going to make that change ?

I am not fully setup here to do that I have a lot on my plate these days. I can however edit the change and drop it here.
Someone else would need push it through.

Issue History

Date Modified Username Field Change
2020-03-12 10:44 Ondrej Pokorny New Issue
2020-03-12 10:44 Ondrej Pokorny Relationship added related to 0036746
2020-03-12 10:45 Ondrej Pokorny Assigned To => Ondrej Pokorny
2020-03-12 10:45 Ondrej Pokorny Status new => assigned
2020-03-13 02:35 jamie philbrook Note Added: 0121577