|
|
tabz.png (4,694 bytes) |
|
|
I've already written to the mailing list: please create simple example project so I don't need to install 3rd party components like ATxxxxx controls. |
|
|
I've tested with svn r60000 (only qt/qt5 widgetset part) (4.1.2019, so 15 months ago) and same problem persists with qt and qt5, so this has nothing to do with my recent changes with stretchMaskBlt(). (linux mint 19.2 64bit, Qt/Qt5). Does your code work ok with cocoa ? |
|
|
i've seen ATTabs code and see it paints triangle over old triangle. trinagle-1 overlaps trinagle-2. so 2 nearest tabs overlap. code gets old rect using Canvas.CopyRect, paints triangle over it. maybe CopyRect has bug. |
|
|
yes, code works ok with Cocoa. and with old Laz 2.1 with qt/qt5. |
|
|
@CudaText man, now with my internal changes in CopyRect() (TQtWidgetSet.StretchMaskBlt()) I have ok image, but problem is that background is black, but under gtk2 it's transparent, so it does not look ok yet. |
|
|
ok, waiting for qt/qt5 fixing. |
|
|
I've lost few hours because trusted in your code. You are painting outside of paint event somewhere in your code and using CopyRect() (or BitBlt, StretchBlt or StretchmaskBlt). Qt, Qt5, cocoa and carbon does not support painting outside of paint event. This is my error log (only TATabs with 2 tabs are on the form). It's clear here that you're copying something from TCustomcontrol to DestDC which is TBitmap in this case, but not inside paint event of TCustomControl. ERROR: SrcDC NOT inside paintEvent...TQtViewPort FOwner TQtCustomControl LCLObject=ATTabs1:TATTabs SrcRect=l=334,t=4,r=344,b=28 DstRect=l=0,t=0,r=50,b=120 destination is QImage with format QImageFormat_RGB32 ERROR: SrcDC NOT inside paintEvent...TQtViewPort FOwner TQtCustomControl LCLObject=ATTabs1:TATTabs SrcRect=l=168,t=4,r=178,b=28 DstRect=l=0,t=0,r=50,b=120 destination is QImage with format QImageFormat_RGB32 ERROR: SrcDC NOT inside paintEvent...TQtViewPort FOwner TQtCustomControl LCLObject=ATTabs1:TATTabs SrcRect=l=306,t=4,r=316,b=28 DstRect=l=0,t=0,r=50,b=120 destination is QImage with format QImageFormat_RGB32 ERROR: SrcDC NOT inside paintEvent...TQtViewPort FOwner TQtCustomControl LCLObject=ATTabs1:TATTabs SrcRect=l=38,t=4,r=48,b=29 DstRect=l=0,t=0,r=50,b=125 destination is QImage with format QImageFormat_RGB32 ERROR: SrcDC NOT inside paintEvent...TQtViewPort FOwner TQtCustomControl LCLObject=ATTabs1:TATTabs SrcRect=l=176,t=4,r=186,b=29 DstRect=l=0,t=0,r=50,b=125 destination is QImage with format QImageFormat_RGB32 Resolved as "no change required". Fix your code. |
|
|
Sorry, it was fault inside my debugging code. ATTabs does not paint outside of paint event |
|
|
It looks to me that you're missing mask on bitmap. Note that copy from screen is much different under X11 than windows. If your window is obscured by some other window it won't work as expected. Currently (in my trunk copy) I've hacked & cheated Qt to render widget (as in TQtWSWinControl.PaintTo()) instead of grabbing window and got result as in attached picture. Triangles are there but they're not masked so you see white stuff around. attabs_missing_mask.png (2,347 bytes) |
|
|
Ok, I've found howto fix it inside ATTabs. CopyRect() from device isn't needed at all (it does exactly nothing). 1.Rename FBitmapAngle to FBitmapAngleL 2.Add FBitmapAngleR (create it same as FBitmapAngleL) 3.In DoPaintTabShape_R() use FBitmapAngleR instead of FBitmapAngleL. 4.In DrawTriangleRectFramed() add this: BitmapSetSize(b, ASizeX*AScale, ASizeY*AScale); // add this b.Canvas.Brush.Style := bsSolid; b.Canvas.Brush.Color := {$IFDEF MSWINDOWS}clWhite{$ELSE}clBlack{$ENDIF}; b.Canvas.FillRect(0, 0, b.Width, b.Height); b.TransparentColor := {$IFDEF MSWINDOWS}clWhite{$ELSE}clBlack{$ENDIF}; b.Transparent := true; 5.Remove below b.Canvas.CopyRect() . Now your code will be even faster (at least under X11) and it will work correct. |
|
|
See results in pictures. All are ok (except gtk3 but that's anothers story since gtk3 drawing isn't perfect yet). EDIT: All screenshoots are maded after changes I've proposed. attabs_gtk3.png (3,504 bytes) attabs_win32_under_wine.png (2,595 bytes) attabs_gtk2.png (3,005 bytes) attabs_qt5.png (3,237 bytes) attabs_qt4.png (3,278 bytes) |
|
|
thanks for your fix. i added this fix to ATtabs. |
|
|
Please close if ok. |
- Anonymous
