View Issue Details

IDProjectCategoryView StatusLast Update
0037032FPCCompilerpublic2020-05-07 22:36
ReporterKai Burghardt Assigned ToFlorian  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Platformx86_64OSGNU/Linux 
Product Version3.0.4 
Fixed in Version3.3.1 
Summary0037032: cpid.pas contains syntax error(s)
DescriptionThe file compiler/cpid.pas contains a syntax error, cf. attached patch.
Additional InformationI’m primarily concerned about line 55 https://svn.freepascal.org/cgi-bin/viewvc.cgi/trunk/compiler/cpid.pas?view=markup&pathrev=19102#l55

Is this file used anyway? Because I can’t imagine this went unnoticed for eight years straight. I don’t we should keep stuff in the repository that isn’t actually needed.
TagsNo tags attached.
Fixed in Revision45306
FPCOldBugId
FPCTarget-
Attached Files

Activities

Kai Burghardt

2020-05-07 08:07

reporter  

cpid.pas.patch (1,084 bytes)   
--- cpid.pas~	2020-05-07 06:05:00.132629186 +0000
+++ cpid.pas	2020-05-07 06:05:00.132629186 +0000
@@ -52,7 +52,7 @@
       id : 863; name : 'IBM863';
       id : 864; name : 'IBM864';
       id : 865; name : 'IBM865';
-      id : 866; name : 'cp866'';;
+      id : 866; name : 'cp866';
       id : 869; name : 'ibm869';
       id : 870; name : 'IBM870';
       id : 874; name : 'windows-874';
@@ -159,13 +159,13 @@
       id : 50227; name : 'x-cp50227';
       id : 50229; name : 'ISO 2022';
       { not unique
-      id : 50930; name : 'EBCDIC
-      id : 50931; name : 'EBCDIC
-      id : 50933; name : 'EBCDIC
-      id : 50935; name : 'EBCDIC
-      id : 50936; name : 'EBCDIC
-      id : 50937; name : 'EBCDIC
-      id : 50939; name : 'EBCDIC
+      id : 50930; name : 'EBCDIC';
+      id : 50931; name : 'EBCDIC';
+      id : 50933; name : 'EBCDIC';
+      id : 50935; name : 'EBCDIC';
+      id : 50936; name : 'EBCDIC';
+      id : 50937; name : 'EBCDIC';
+      id : 50939; name : 'EBCDIC';
       }
       id : 51932; name : 'euc-jp';
       id : 51936; name : 'EUC-CN';
cpid.pas.patch (1,084 bytes)   

Christo Crause

2020-05-07 22:05

reporter   ~0122660

The cpid unit does indeed appear abandoned. The only honorable mention is in ppc8086.lpi:
~/fpc/3.3.1/compiler$ rgrep cpid -I
pcp.pas: function checkpcpid:boolean;
pcp.pas: function tpcpfile.checkpcpid:boolean;
ppc8086.lpi: <Filename Value="cpid.pas"/>
fpcp.pas: if not pcpfile.checkpcpid then
cpid.pas:unit cpid;

No surprise then that the finger trouble you picked up wasn't noticed before.

Christo Crause

2020-05-07 22:07

reporter   ~0122661

It appears the cwindirs unit is also unused, which is no surprise given the temporary nature of the last commit message.

Florian

2020-05-07 22:36

administrator   ~0122663

Thanks, removed.

Issue History

Date Modified Username Field Change
2020-05-07 08:07 Kai Burghardt New Issue
2020-05-07 08:07 Kai Burghardt File Added: cpid.pas.patch
2020-05-07 22:05 Christo Crause Note Added: 0122660
2020-05-07 22:07 Christo Crause Note Added: 0122661
2020-05-07 22:36 Florian Assigned To => Florian
2020-05-07 22:36 Florian Status new => resolved
2020-05-07 22:36 Florian Resolution open => fixed
2020-05-07 22:36 Florian Fixed in Version => 3.3.1
2020-05-07 22:36 Florian Fixed in Revision => 45306
2020-05-07 22:36 Florian FPCTarget => -
2020-05-07 22:36 Florian Note Added: 0122663