View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0037115 | FPC | Packages | public | 2020-05-19 18:27 | 2021-04-11 19:47 |
| Reporter | Dmitriy A. Voroshin | Assigned To | Michael Van Canneyt | ||
| Priority | normal | Severity | minor | Reproducibility | N/A |
| Status | resolved | Resolution | fixed | ||
| Product Version | 3.0.4 | ||||
| Target Version | 3.2.2 | Fixed in Version | 3.2.2 | ||
| Summary | 0037115: HTTPDefs.pp TCookie doesn't support sameSite attribute | ||||
| Description | sameSite recomendend attribte going to be required, but not supportd TCookie class. https://developer.mozilla.org/en-US/docs/Web/HTTP/Cookies I suggest making the following changes to the files HTTPDefs.pp and httpprotocol.pp couldn't make diff. attach whole patched files | ||||
| Tags | No tags attached. | ||||
| Fixed in Revision | 48901 merged 46588 | ||||
| FPCOldBugId | |||||
| FPCTarget | 4.0.0 | ||||
| Attached Files |
| ||||
|
|
|
|
|
Added support for SameSite attribute, but I used an enumerated for the TCookie property. Thanks for reporting ! |
|
|
An error was made in forming the string. You must use an equal sign instead of a colon. instead: if FSameSite<>ssEmpty then AddToResult(SCookieSameSite+': '+SSameSiteValues[FSameSite]); must be if FSameSite<>ssEmpty then AddToResult(SCookieSameSite+'='+SSameSiteValues[FSameSite]); |
|
|
Changed as suggested, thanks for pointing it out! |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2020-05-19 18:27 | Dmitriy A. Voroshin | New Issue | |
| 2020-05-19 18:27 | Dmitriy A. Voroshin | File Added: sameSite.7z | |
| 2020-05-19 18:48 | Michael Van Canneyt | Assigned To | => Michael Van Canneyt |
| 2020-05-19 18:48 | Michael Van Canneyt | Status | new => assigned |
| 2020-05-20 11:38 | Michael Van Canneyt | Status | assigned => resolved |
| 2020-05-20 11:38 | Michael Van Canneyt | Resolution | open => fixed |
| 2020-05-20 11:38 | Michael Van Canneyt | Fixed in Version | => 3.3.1 |
| 2020-05-20 11:38 | Michael Van Canneyt | Fixed in Revision | => 45447 |
| 2020-05-20 11:38 | Michael Van Canneyt | FPCTarget | => 4.0.0 |
| 2020-05-20 11:38 | Michael Van Canneyt | Note Added: 0122951 | |
| 2021-02-22 15:39 | Dmitriy A. Voroshin | Status | resolved => feedback |
| 2021-02-22 15:39 | Dmitriy A. Voroshin | Resolution | fixed => open |
| 2021-02-22 15:39 | Dmitriy A. Voroshin | Note Added: 0129102 | |
| 2021-03-07 20:05 | Michael Van Canneyt | Status | feedback => resolved |
| 2021-03-07 20:05 | Michael Van Canneyt | Resolution | open => fixed |
| 2021-03-07 20:05 | Michael Van Canneyt | Fixed in Revision | 45447 => 48901 |
| 2021-03-07 20:05 | Michael Van Canneyt | Note Added: 0129495 | |
| 2021-04-11 19:47 | Marco van de Voort | Fixed in Version | 3.3.1 => 3.2.2 |
| 2021-04-11 19:47 | Marco van de Voort | Target Version | => 3.2.2 |
| 2021-04-11 19:47 | Marco van de Voort | Fixed in Revision | 48901 => 48901 merged 46588 |
