|
|
After some more debugging, I've found if you drop a combobox on the form. Set the style := csSimple.. at this point you are not able to size it from the IDE. Save the project you are doing this in, close the project. reopen the project and don't change the style settings. Now you can resize the combobox in the IDE with the grippers. It seems you have to go through this process to force the IDE to accept the fact that you want to size the csSimple combobox at design time. Also, with the garbage displaying at the bottom of the list for the csSimple... This is due to the host window being taller than the actual list box itself. I overroad the CreateParams and added this to the Style member. CBS_NOINTEGRALHEIGHT I do this only if the csSimple is in play, otherwise it stays as is.. I was going to adjust the host window height to fit the OS determined height in the Createhandle code but i got thinking that could cause issues with Dragging the size in the IDE. What do you think of this issue this far ? |
|
|
I will try to get setup for proper patches, but the last time I tried this it was a hora show.. Things just wasn't going well on my end.. I Added this to the Combobox.CreateParams method in the Combobox.inc file. {$IFDEF Windows} //Added JP. if (Params.Style and CBS_SIMPLE)<>0 Then Begin Include(FWinControlFlags, wcfEraseBackground); Params.Style:= Params.Style or $400; //CBS_NOINTEGRALHEIGHT End Else Exclude(FWinControlFlags, wcfEraseBackground); {$IFEND} This is placed at the bottom of the Method call. This corrects the garbage drawing of the csSimple combobox because it needs to have its background erased and it also needs to be in Non-integral height mode because it too also generates a white background at the bottom depending on height. This code only effects the csSimple, all other styles still work as they are now. I still haven't found the issue with the designer but I can tell you how to make it work.. It appears you need to set the style of the combo box to csSimple for what at this time you still can not size the box. save the project, close it, reopen the project. The settings are still csSimple but now you can resize the csSimple on the form using the OI.. That has me puzzled ? working with your project from there on will keep the box sizeable until you toggle the styles again. Then you need to reload the project. |
|
|
I am adding a demo project which shows the "garbage" at the bottom of the csSimple combo (left most combobox - the other one is just for reference to a csDropdown combobox). To verify click the "Height = 162" button and then several times the "Dec Height by 10". 37129.png (6,278 bytes) |
|
|
The issue was discussed in the forum (https://forum.lazarus.freepascal.org/index.php/topic,49911.0.html). Jamie provided there a modified version of the Win32 widgetset file win32wsstdctrls.pp from which I created the attached patch. It is essentially jamie's idea to deactivate the integral listbox height feature, but transferred into the win32 widgetset (in the other widgetsets the csSimple combobox does not show a stationary listbox). This modified version does resolve the "garbage" issue, but leaves other issues: - When the height of the csSimple combobox is set by code (button "Height = 162") an explicit call to Combobox.Invalidate is required (check "call Invalidate after click"), otherwise the stationary listbox will not be painted fully. - AutoSize is not operational: Once the height of the csSimple combobox has been changed it cannot be reset to its original height by setting AutoSize to true (Click "Height=162" and then "AutoSize" --> no change). - As already mentioned by jamie here, the height of a csSimple combobox cannot be changed at designtime after the combobox has been dropped onto the form. It is required to save the form and reload it to make the height changeable. win32wsstdctrls.pp.patch (2,414 bytes) |
|
|
I had to revert the GetPreferredSize back to its original state because it is causing the size change of the combobox to be limited to ~ 50 or so times, after that changing the Height has no effect. So I put it back as it was before so if it is csSimple it returns 0 as the preferred size for now.. |
|
|
After spending more time on this topic than I did before and comparing the state before and after the patch, it looks to me as if the initial idea with the integral line height has led you onto the wrong path, and this hides the real root cause of incorrect erasing the background of the stationary listbox - as if the WM_ERASEBKGND message does not reach the stationary listbox or is not property handled by it. |
|
|
OK, I'll go with that for the time being.. But where is the code that draws the borders? Changing a windows setting in the control seems to correct the inner bevel or outline depending if you are using themes or not to force the correct size for the outline.. You can get the rectangle size of the listbox from Windows but I thinking that maybe some how the size of the font is being used. If the LCL is responsible for the border drawing I would like to know where to look.. that I have been searching .. Actually I don't know why we don't have a Property for integralHeight anyways ? Its in both Listbox and Combos. |
|
|
I had to implement the WM_SETFONT because when ever the font was set it caused windows to size its box larger than the host box so there was no scrollbar showing depending on the size of the font also cause the box length to exceed the host box.. Also I still can not remove the use of the CB_NOINTEGRALHEIGHT and of course I had to ensure the background erase was on in the LCL code... I've tested this with code sizing in all directions, anchoring etc. This works smoothing both in the designer and at runtime.. I did have an issue with tricking the system to accept a size change so it would update. It seems there is block somewhere, maybe in the LCL preventing refresh painting of the same size bounds. If you have a better solution for this it would be nice . what I have now seems to actually work and it works very nicely here. Code below.. ----- WM_SETFONT: {JP added} Begin Result := WindowProc(Window, Msg, WParam, LParam); WindowInfo := GetWin32WIndowInfo(Window); With WindowInfo^.WinControl Do Begin {LCL is blcoking the size change so we trick it} If TCustomComBoBox(WindowInfo^.WinCOntrol).Style = csSimple Then Begin SendMessage(Window,CB_SETDROPPEDWIDTH, WIdth, 0); MoveWindow(Handle, left,Top,Width, Height-1,False); {Trick the No size lock} MoveWindow(Handle, Left,Top,Width, Height+1,False);{Won't change otherwise} end; end; Exit; end; WM_SIZE: {JP added for csSimple border painting with the list in view} begin Result := WindowProc(Window, Msg, WParam, LParam);//call original firt; WindowInfo := GetWin32WindowInfo(Window); If TCustomcombobox(WindowInfo^.WinControl).Style = csSimple Then Begin InvalidateRect(WindowInfo^.WinControl.Handle,Nil,true);{border does not paint properly otherwise} end; Exit; end; {/jp} --- and the CreateHandle for the customComboBox This section as we talk about before. // create window If (CBS_SIMPLE and Params.flags)<>0 Then {JP csSimple comboboxes don't paint correctly otherwise.} begin Params.Flags := Params.Flags or CBS_NOINTEGRALHEIGHT; Include(TWinControlAccess(AWinControl).FWinControlFlags, wcfEraseBackground); end; FinishCreateWindow(AWinControl, Params, False, True); Now I just need to figure out why the designer is not allowing the csSimple to size without reloading project. |
|
|
Looks good! |
|
|
Resolved, since the issue reported is fixed now without side-effects. Thank you for your effort - great work! Please test again, and close if ok. If you should find a solution for the need to save and re-open the project to see the static listbox you should put this into a separate report. |
|
|
Side effect 0037670 |
|
|
Drop count has nothing to do with the csSimple code, I have no idea how that came about but it's most likely else where. Reverting will only make the csSimple its static list box visible unusable since all that was done was to fix a redrawing issue. There was nothing changed that had anything to do with drop down counts.. Most likely something else got changed after the fact. Please look deeper.. Also you'll note that the csSimple still has an issue with you initially put it in csSimple style in the designer, you need to reload your all and after that the box is sizeable. |
- Anonymous
