View Issue Details

IDProjectCategoryView StatusLast Update
0037167LazarusIDEpublic2020-06-02 16:25
ReporterJoeny Ang Assigned ToMartin Friebe  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version2.1 (SVN) 
Summary0037167: [Patch] DebugLn is not outputting new line characters
DescriptionAfter recent update, DebugLn is not outputting new line characters anymore. ("Console In/Output" window - TPseudoConsoleDlg).
TagsNo tags attached.
Fixed in Revision63279
LazTarget-
WidgetsetGTK 2
Attached Files

Relationships

related to 0036898 resolvedMartin Friebe Console In/Out Window adds extra linefeeds under Linux 

Activities

Joeny Ang

2020-06-02 08:58

reporter  

debugger-pseudoterminaldlg-EOL-bug.patch (527 bytes)   
--- debugger/pseudoterminaldlg.pp
+++ debugger/pseudoterminaldlg.pp
@@ -757,7 +757,7 @@
 (* "interesting" behavior once the amount of text causes it to start scrolling  *)
 (* so having an intermediate that can be inspected might be useful.             *)
 
-  TextEndsInEOL := (AText <> '') and (AText[Length(AText)-1] in [#10]);
+  TextEndsInEOL := (AText <> '') and (AText[Length(AText)] in [#10]);
   buffer := TStringList.Create;
   try
     buffer.Text := AText;     (* Decides what line breaks it wants to swallow   *)

Juha Manninen

2020-06-02 09:00

developer   ~0123183

Last edited: 2020-06-02 09:02

View 3 revisions

Should it be [# 10, # 13] instead of [# 10] ?
(Spaces were added because of the Mantis SW interpreter).

Joeny Ang

2020-06-02 09:13

reporter   ~0123184

That line was added recently, r63132, I believe. I just removed the "-1" since it is getting the last char of a string, to which index is 1-based.

Martin Friebe

2020-06-02 16:25

manager   ~0123192

Fixed.

About # 13
This is only used for linux, so # 13 is not a linebreak.

Issue History

Date Modified Username Field Change
2020-06-02 08:58 Joeny Ang New Issue
2020-06-02 08:58 Joeny Ang File Added: debugger-pseudoterminaldlg-EOL-bug.patch
2020-06-02 09:00 Juha Manninen Note Added: 0123183
2020-06-02 09:01 Juha Manninen Note Edited: 0123183 View Revisions
2020-06-02 09:02 Juha Manninen Note Edited: 0123183 View Revisions
2020-06-02 09:13 Joeny Ang Note Added: 0123184
2020-06-02 09:34 Juha Manninen Relationship added related to 0036898
2020-06-02 09:35 Juha Manninen Assigned To => Martin Friebe
2020-06-02 09:35 Juha Manninen Status new => assigned
2020-06-02 16:25 Martin Friebe Status assigned => resolved
2020-06-02 16:25 Martin Friebe Resolution open => fixed
2020-06-02 16:25 Martin Friebe Fixed in Revision => 63279
2020-06-02 16:25 Martin Friebe LazTarget => -
2020-06-02 16:25 Martin Friebe Widgetset GTK 2 => GTK 2
2020-06-02 16:25 Martin Friebe Note Added: 0123192