All Projects FPC fpcprojects fpprofilerfpGUI Lazarus Packages PatchesLazarus CCR Mantis pas2js

View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0037483FPCFCLpublic2020-08-04 15:512020-11-13 21:46
ReporterC Western Assigned ToMichael Van Canneyt  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
PlatformWindows 
Product Version3.3.1 
Fixed in Version3.3.1 
Summary0037483: Patch for TRegIniFile.CloseSection
DescriptionWithout the attached patch, the sequence:

  IniSettings :=TRegistryIniFile.Create(KeyName)
  try
    IniSettings.ReadSectionValues(AutoSaveKey, Files);
  finally
    IniSettings.Free;
  end;

crashes, as a key is closed twice.
Additional InformationRelated to 0036663: Broken TRegistryIniFile
TagsNo tags attached.
Fixed in Revision47410
FPCOldBugId
FPCTarget3.2.2
Attached Files

Activities

C Western

2020-08-04 15:51

reporter  

regini.inc.patch (322 bytes)    
Index: fcl-registry/src/regini.inc
===================================================================
--- fcl-registry/src/regini.inc	(revision 46225)
+++ fcl-registry/src/regini.inc	(working copy)
@@ -318,5 +318,6 @@
 procedure TRegIniFile.CloseSection;
 begin
   CloseKey(CurrentKey);
+  fCurrentKey := 0;
 end;
regini.inc.patch (322 bytes)   

Michael Van Canneyt

2020-11-13 21:46

administrator   ~0126894

Applied, thanks for the patch !

Issue History

Date Modified Username Field Change
2020-08-04 15:51 C Western New Issue
2020-08-04 15:51 C Western File Added: regini.inc.patch
2020-11-13 21:46 Michael Van Canneyt Assigned To => Michael Van Canneyt
2020-11-13 21:46 Michael Van Canneyt Status new => resolved
2020-11-13 21:46 Michael Van Canneyt Resolution open => fixed
2020-11-13 21:46 Michael Van Canneyt Fixed in Version => 3.3.1
2020-11-13 21:46 Michael Van Canneyt Fixed in Revision => 47410
2020-11-13 21:46 Michael Van Canneyt FPCTarget => 3.2.2
2020-11-13 21:46 Michael Van Canneyt Note Added: 0126894