CocoaThemes.IsAppDark & IsWinDark aren't correct with dark system style
Original Reporter info from Mantis: zpeterson @boramis
-
Reporter name: Zoë Peterson
Original Reporter info from Mantis: zpeterson @boramis
- Reporter name: Zoë Peterson
Description:
CocoaThemes's IsAppDark and IsWinDark both look at NSApp.appearance to see what the current appearance is and should be using effectiveAppearance instead. appearance is what the program has explicitly set and may be nil. effectiveAppearance will return appearance if it's set and falls back to the system appearance if it isn't. The current behavior will return False for both functions if you don't set appearance explicitly but do have the system in dark mode. The attached patch fixes the issue so they return True instead.
Steps to reproduce:
Create a new LCL Cocoa app that updates its caption based on the results of CocoaThemes.IsAppDark. Set the operating system to dark mode.
Mantis conversion info:
- Mantis ID: 37617
- Version: 2.0.10
- Fixed in revision: 63818 (#f0b7aadf)