View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0037625 | FPC | Compiler | public | 2020-08-23 00:10 | 2020-12-31 12:07 |
| Reporter | CudaText man_ | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | new | Resolution | open | ||
| OS | Ubuntu 20 x64 | ||||
| Product Version | 3.3.1 | ||||
| Summary | 0037625: SigSegv in TRegExpr fork | ||||
| Description | This demo https://github.com/Alexey-T/ATSynEdit/tree/master/app/demo_editor crashes inside function
function TRegExpr.regnext(p: PRegExprChar): PRegExprChar;
// dig the "next" pointer out of a node
var
offset: TRENextOff;
begin
if p = @regdummy then
begin
Result := nil;
Exit;
end;
offset := PRENextOff(AlignToPtr(p + REOpSz))^; // here
it works Ok with FPC 3.2. | ||||
| Tags | No tags attached. | ||||
| Fixed in Revision | |||||
| FPCOldBugId | |||||
| FPCTarget | |||||
| Attached Files |
| ||||
|
|
The file name: atsynedit/atsynedit_regexpr.pas. |
|
|
May I know if there are any prospects for solving this issue? |
|
|
As the bugreport is some external fork (why is it here?) I don't know the prospects. The report is a bit thin to be about a compiler bug. If I look at the function facevalue, it doesn't check for p=nil, while it does check for assigned(p). If for some reason the forked version sometimes resets to nil (or some other value) and not @regdummy crashes are bound to happen. |
|
|
Maybe include the original TRegExpr from Github? Doesn't make sense to "maintain" two versions while the FPC on is barely maintained and the Github one got a lot of nice features recently (fixes e.g. 0029756) and does not have any known bugs. |
|
|
FPC should focus on Compiler/RTL and not on 3rd party packages which are well maintained by others - just include their recent work |
|
|
Ravi dion: please use maillists and forum for discussion. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2020-08-23 00:10 | CudaText man_ | New Issue | |
| 2020-08-23 00:14 | CudaText man_ | Note Added: 0125087 | |
| 2020-12-27 22:08 | zoltanleo | Note Added: 0127841 | |
| 2020-12-31 10:25 | Marco van de Voort | Note Added: 0127965 | |
| 2020-12-31 11:25 | ravi dion | Note Added: 0127966 | |
| 2020-12-31 11:26 | ravi dion | Note Added: 0127967 | |
| 2020-12-31 12:07 | Marco van de Voort | Note Added: 0127969 |
