View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0037758 | FPC | Packages | public | 2020-09-16 20:43 | 2020-09-16 21:17 |
| Reporter | Joe care | Assigned To | Michael Van Canneyt | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Platform | x86-64 | OS | Win64 | ||
| Product Version | 3.3.1 | ||||
| Fixed in Version | 3.3.1 | ||||
| Summary | 0037758: Array-Parmeter have wrong brackets '(' insted of '[' | ||||
| Description | function TParamsExpr.GetDeclaration(full: Boolean): string; Writes Arrayvar(someExpression) but it should give Arrayvar[SomeExpresion] | ||||
| Steps To Reproduce | Parse : const c:array[0..1] of byte = (1,2); begin write(c[0]); end. PasWrite produces: program test; const c : Array[0..1] of Byte = (1, 2); begin write(c(0)); end. | ||||
| Additional Information | Provided patch ... | ||||
| Tags | pass-rc | ||||
| Fixed in Revision | 46878 | ||||
| FPCOldBugId | |||||
| FPCTarget | 3.2.2 | ||||
| Attached Files |
| ||||
|
|
pastree.patch (412 bytes)
Index: pastree.pp
===================================================================
--- pastree.pp (Revision 46877)
+++ pastree.pp (Arbeitskopie)
@@ -5724,7 +5724,7 @@
Result:=Result+', ';
Result:=Result+Params[I].GetDeclaration(Full);
end;
- if Kind = pekSet then
+ if Kind in [pekSet,pekArrayParams] then
Result := '[' + Result + ']'
else
Result := '(' + Result + ')';
|
|
|
It's about Pass-Rc (sorry, forgot to mention it) |
|
|
Checked and applied, thank you very much ! |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2020-09-16 20:43 | Joe care | New Issue | |
| 2020-09-16 20:43 | Joe care | File Added: pastree.patch | |
| 2020-09-16 20:44 | Joe care | Tag Attached: pass-rc | |
| 2020-09-16 20:46 | Joe care | Note Added: 0125576 | |
| 2020-09-16 21:17 | Michael Van Canneyt | Assigned To | => Michael Van Canneyt |
| 2020-09-16 21:17 | Michael Van Canneyt | Status | new => resolved |
| 2020-09-16 21:17 | Michael Van Canneyt | Resolution | open => fixed |
| 2020-09-16 21:17 | Michael Van Canneyt | Fixed in Version | => 3.3.1 |
| 2020-09-16 21:17 | Michael Van Canneyt | Fixed in Revision | => 46878 |
| 2020-09-16 21:17 | Michael Van Canneyt | FPCTarget | => 3.2.2 |
| 2020-09-16 21:17 | Michael Van Canneyt | Note Added: 0125579 |
