View Issue Details

IDProjectCategoryView StatusLast Update
0037941LazarusPrinterpublic2020-10-17 19:01
ReporterDon Siders Assigned ToJuha Manninen  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version2.1 (SVN) 
Summary0037941: [PATCH] Fix spelling error in printers.pas and printer4lazarus pacakage
DescriptionParameter name aAborded changed to aAborted.

See attached: fix-aborded.diff
TagsNo tags attached.
Fixed in Revisionr64039
LazTarget-
Widgetset
Attached Files

Activities

Don Siders

2020-10-17 05:28

reporter  

fix-aborded.diff (5,450 bytes)   
Index: components/printers/carbon/carbonprinters.inc
===================================================================
--- components/printers/carbon/carbonprinters.inc	(revision 64031)
+++ components/printers/carbon/carbonprinters.inc	(working copy)
@@ -432,9 +432,9 @@
   BeginPage;
 end;
 
-procedure TCarbonPrinter.DoEndDoc(aAborded: Boolean);
+procedure TCarbonPrinter.DoEndDoc(aAborted: Boolean);
 begin
-  inherited DoEndDoc(aAborded);
+  inherited DoEndDoc(aAborted);
 
   EndPage;
   if FBeginDocumentStatus = noErr then
Index: components/printers/carbon/carbonprinters_h.inc
===================================================================
--- components/printers/carbon/carbonprinters_h.inc	(revision 64031)
+++ components/printers/carbon/carbonprinters_h.inc	(working copy)
@@ -57,7 +57,7 @@
   protected
     procedure DoBeginDoc; override;
     procedure DoNewPage; override;
-    procedure DoEndDoc(aAborded : Boolean); override;
+    procedure DoEndDoc(aAborted : Boolean); override;
     procedure DoAbort; override;
 
     procedure DoEnumPrinters(Lst : TStrings); override;
Index: components/printers/cocoa/cocoaprinters.inc
===================================================================
--- components/printers/cocoa/cocoaprinters.inc	(revision 64031)
+++ components/printers/cocoa/cocoaprinters.inc	(working copy)
@@ -636,7 +636,7 @@
     Error('Error on getting DestinationType');
 end;
 
-procedure TCocoaPrinter.DoEndDoc(aAborded: Boolean);
+procedure TCocoaPrinter.DoEndDoc(aAborted: Boolean);
 var
   preview: TCocoaPrinterView;
   op: NSPrintOperation;
@@ -647,7 +647,7 @@
   if not fDocStarted then
     exit;
 
-  if aAborded then
+  if aAborted then
   begin
     // TODO: check leaks ...
   end;
Index: components/printers/cocoa/cocoaprinters_h.inc
===================================================================
--- components/printers/cocoa/cocoaprinters_h.inc	(revision 64031)
+++ components/printers/cocoa/cocoaprinters_h.inc	(working copy)
@@ -91,7 +91,7 @@
     procedure DoBeginDoc; override;
     procedure DoBeginPage; override;
     procedure DoEndPage; override;
-    procedure DoEndDoc(aAborded : Boolean); override;
+    procedure DoEndDoc(aAborted : Boolean); override;
     procedure DoAbort; override;
 
     procedure DoEnumPrinters(Lst : TStrings); override;
Index: components/printers/qt/qtprinters.inc
===================================================================
--- components/printers/qt/qtprinters.inc	(revision 64031)
+++ components/printers/qt/qtprinters.inc	(working copy)
@@ -383,12 +383,12 @@
   QtDefaultPrinter.NewPage;
 end;
 
-procedure TQtPrinters.DoEndDoc(aAborded: Boolean);
+procedure TQtPrinters.DoEndDoc(aAborted: Boolean);
 begin
   {$IFDEF VERBOSE_QT_PRINTING}
   DebugLn('TQtPrinters.DoEndDoc()');
   {$ENDIF}
-  inherited DoEndDoc(aAborded);
+  inherited DoEndDoc(aAborted);
   EndPage;
 end;
 
Index: components/printers/qt/qtprinters_h.inc
===================================================================
--- components/printers/qt/qtprinters_h.inc	(revision 64031)
+++ components/printers/qt/qtprinters_h.inc	(working copy)
@@ -46,7 +46,7 @@
   protected
     procedure DoBeginDoc; override;
     procedure DoNewPage; override;
-    procedure DoEndDoc(aAborded : Boolean); override;
+    procedure DoEndDoc(aAborted : Boolean); override;
     procedure DoAbort; override;
 
     procedure DoEnumPrinters(Lst : TStrings); override;
Index: components/printers/win32/winprinters.inc
===================================================================
--- components/printers/win32/winprinters.inc	(revision 64031)
+++ components/printers/win32/winprinters.inc	(working copy)
@@ -326,9 +326,9 @@
     Windows.EndPage(fDC);
 end;
 
-procedure TWinPrinter.DoEndDoc(aAborded: Boolean);
+procedure TWinPrinter.DoEndDoc(aAborted: Boolean);
 begin
-  inherited DoEndDoc(aAborded);
+  inherited DoEndDoc(aAborted);
 
   if RawMode then begin
 
@@ -340,7 +340,7 @@
     }
   end else begin
     Windows.EndPage(fDC);
-    if not aAborded then
+    if not aAborted then
       WinUtilPrn.EndDoc(fDC);
   end;
 end;
Index: components/printers/win32/winprinters_h.inc
===================================================================
--- components/printers/win32/winprinters_h.inc	(revision 64031)
+++ components/printers/win32/winprinters_h.inc	(working copy)
@@ -46,7 +46,7 @@
     procedure DoNewPage; override;
     procedure DoBeginPage; override;
     procedure DoEndPage; override;
-    procedure DoEndDoc(aAborded : Boolean); override;
+    procedure DoEndDoc(aAborted : Boolean); override;
     procedure DoAbort; override;
 
     procedure DoEnumPrinters(Lst : TStrings); override;
Index: lcl/printers.pas
===================================================================
--- lcl/printers.pas	(revision 64031)
+++ lcl/printers.pas	(working copy)
@@ -239,7 +239,7 @@
      procedure DoNewPage; virtual;
      procedure DoBeginPage; virtual;
      procedure DoEndPage; virtual;
-     procedure DoEndDoc(aAborded : Boolean); virtual;
+     procedure DoEndDoc(aAborted : Boolean); virtual;
      procedure DoAbort; virtual;
      procedure DoResetPrintersList; virtual;
      procedure DoResetFontsList; virtual;
@@ -828,7 +828,7 @@
   //Override this method
 end;
 
-procedure TPrinter.DoEndDoc(aAborded : Boolean);
+procedure TPrinter.DoEndDoc(aAborted : Boolean);
 begin
   //Override this method
 end;
fix-aborded.diff (5,450 bytes)   

Juha Manninen

2020-10-17 18:42

developer   ~0126372

Applied, thanks.

Issue History

Date Modified Username Field Change
2020-10-17 05:28 Don Siders New Issue
2020-10-17 05:28 Don Siders File Added: fix-aborded.diff
2020-10-17 18:42 Juha Manninen Assigned To => Juha Manninen
2020-10-17 18:42 Juha Manninen Status new => resolved
2020-10-17 18:42 Juha Manninen Resolution open => fixed
2020-10-17 18:42 Juha Manninen Fixed in Revision => r64039
2020-10-17 18:42 Juha Manninen LazTarget => -
2020-10-17 18:42 Juha Manninen Note Added: 0126372
2020-10-17 19:01 Don Siders Status resolved => closed