View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0038023 | FPC | RTL | public | 2020-11-02 12:13 | 2020-11-03 13:46 |
Reporter | CudaText man_ | Assigned To | Sven Barth | ||
Priority | normal | Severity | minor | Reproducibility | N/A |
Status | closed | Resolution | fixed | ||
Product Version | 3.3.1 | ||||
Fixed in Version | 3.3.1 | ||||
Summary | 0038023: UTF8ToUnicode micro optimization | ||||
Description | https://github.com/graemeg/freepascal/blob/master/rtl/inc/ustrings.inc Func has 2 places like this: if IBYTE = 10 then begin (* if (PreChar<>13) and FALSE then begin //Expand to crlf, conform UTF-8. //This procedure will break the memory alocation by //FPC for the widestring, so never use it. Condition never true due the "and FALSE". inc(OutputUnicode,2); PreChar:=10; end else *) begin inc(OutputUnicode); PreChar:=IBYTE; end; end else begin inc(OutputUnicode); PreChar:=IBYTE; end; 2 places. lines 1836, 1981. Not needed "if IBYTE=10" and then/else with same content. | ||||
Tags | No tags attached. | ||||
Fixed in Revision | 47284 | ||||
FPCOldBugId | |||||
FPCTarget | - | ||||
Attached Files |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2020-11-02 12:13 | CudaText man_ | New Issue | |
2020-11-02 17:43 | Sven Barth | Assigned To | => Sven Barth |
2020-11-02 17:43 | Sven Barth | Status | new => resolved |
2020-11-02 17:43 | Sven Barth | Resolution | open => fixed |
2020-11-02 17:43 | Sven Barth | Fixed in Version | => 3.3.1 |
2020-11-02 17:43 | Sven Barth | Fixed in Revision | => 47284 |
2020-11-02 17:43 | Sven Barth | FPCTarget | => - |
2020-11-02 17:43 | Sven Barth | Note Added: 0126698 | |
2020-11-03 13:46 | CudaText man_ | Status | resolved => closed |