View Issue Details

IDProjectCategoryView StatusLast Update
0038023FPCRTLpublic2020-11-03 13:46
ReporterCudaText man_ Assigned ToSven Barth  
PrioritynormalSeverityminorReproducibilityN/A
Status closedResolutionfixed 
Product Version3.3.1 
Fixed in Version3.3.1 
Summary0038023: UTF8ToUnicode micro optimization
Descriptionhttps://github.com/graemeg/freepascal/blob/master/rtl/inc/ustrings.inc
Func has 2 places like this:

                if IBYTE = 10 then
                  begin
(*
                    if (PreChar<>13) and FALSE then
                      begin
                        //Expand to crlf, conform UTF-8.
                        //This procedure will break the memory alocation by
                        //FPC for the widestring, so never use it. Condition never true due the "and FALSE".
                        inc(OutputUnicode,2);
                        PreChar:=10;
                      end
                    else
*)
                      begin
                        inc(OutputUnicode);
                        PreChar:=IBYTE;
                      end;
                  end
                else
                  begin
                    inc(OutputUnicode);
                    PreChar:=IBYTE;
                  end;


2 places. lines 1836, 1981.
Not needed "if IBYTE=10" and then/else with same content.
TagsNo tags attached.
Fixed in Revision47284
FPCOldBugId
FPCTarget-
Attached Files

Activities

Sven Barth

2020-11-02 17:43

manager   ~0126698

Please test and close if okay.

Issue History

Date Modified Username Field Change
2020-11-02 12:13 CudaText man_ New Issue
2020-11-02 17:43 Sven Barth Assigned To => Sven Barth
2020-11-02 17:43 Sven Barth Status new => resolved
2020-11-02 17:43 Sven Barth Resolution open => fixed
2020-11-02 17:43 Sven Barth Fixed in Version => 3.3.1
2020-11-02 17:43 Sven Barth Fixed in Revision => 47284
2020-11-02 17:43 Sven Barth FPCTarget => -
2020-11-02 17:43 Sven Barth Note Added: 0126698
2020-11-03 13:46 CudaText man_ Status resolved => closed