View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0038133 | FPC | RTL | public | 2020-11-25 16:33 | 2021-03-23 12:41 |
Reporter | Bi0T1N | Assigned To | Michael Van Canneyt | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | duplicate | ||
Product Version | 3.3.1 | ||||
Fixed in Version | 3.3.1 | ||||
Summary | 0038133: Duplicate function for HexToBin and BinToHex | ||||
Description | I'm not really sure, maybe there is a reason for this but in rtl/objpas/classes/classesh.inc there is
with the implementation in rtl/objpas/classes/util.inc. Exactly the same appears again in packages/rtl-objpas/src/inc/strutils.pp - so maybe remove one of it to avoid code duplication? | ||||
Tags | No tags attached. | ||||
Fixed in Revision | |||||
FPCOldBugId | |||||
FPCTarget | 4.0.0 | ||||
Attached Files |
|
duplicate of | 0038150 | closed | Michael Van Canneyt | [Patch] Implement BinToHex overloads for Delphi compatibility |
|
I assume you meant HexToBin instead of LineStart? ;) For what it's worth: Delphi has them in unit Classes (though Delphi does not seem to have the other overloads we have in StrUtils). Also Delphi supports quite some more overloads: http://docwiki.embarcadero.com/Libraries/Sydney/en/System.Classes.BinToHex Same also for HexToBin: http://docwiki.embarcadero.com/Libraries/Sydney/en/System.Classes.HexToBin |
|
Oh yes, you're absolutely right - I've copied the wrong line. Should be
Correct, that's how I've stumbled about it as I wanted to provide the missing overloads... |
Date Modified | Username | Field | Change |
---|---|---|---|
2020-11-25 16:33 | Bi0T1N | New Issue | |
2020-11-25 23:10 | Sven Barth | Note Added: 0127192 | |
2020-11-26 16:26 | Bi0T1N | Note Added: 0127199 | |
2020-11-29 22:30 | Michael Van Canneyt | Assigned To | => Michael Van Canneyt |
2020-11-29 22:30 | Michael Van Canneyt | Status | new => assigned |
2020-11-29 22:36 | Michael Van Canneyt | Relationship added | related to 0038150 |
2021-03-14 16:42 | Michael Van Canneyt | Status | assigned => resolved |
2021-03-14 16:42 | Michael Van Canneyt | Resolution | open => duplicate |
2021-03-14 16:42 | Michael Van Canneyt | Fixed in Version | => 3.3.1 |
2021-03-14 16:42 | Michael Van Canneyt | FPCTarget | => 4.0.0 |
2021-03-14 16:42 | Michael Van Canneyt | Relationship replaced | duplicate of 0038150 |
2021-03-23 12:41 | Bi0T1N | Status | resolved => closed |