View Issue Details

IDProjectCategoryView StatusLast Update
0038156FPCCompilerpublic2020-12-07 09:12
ReporterJ. Gareth Moreton Assigned ToPierre Muller  
PrioritylowSeverityfeatureReproducibilityN/A
Status resolvedResolutionfixed 
PlatformCross-platformOSMicrosoft Windows 
Product Version3.3.1 
Fixed in Version3.3.1 
Summary0038156: [Patch] XML node dump extension
DescriptionThis patch extends the DEBUG_NODE_XML debug feature by also outputting, to the *-node-dump.xml files, the node tree as it appears after the first pass, since it often contains many more internal nodes like temporary allocations that may need to be evaluated for debugging and development purposes, or node-level optimisation opportunities.
Steps To ReproduceApply patch and confirm zero difference to compilation if DEBUG_NODE_XML is not defined, and the presence of a "firstpass" tag for subroutines in the *-node-dump.xml files when it is defined.
Additional InformationThis feature, temporarily enabled, allowed me to better investigate 0038129 and find a solution.

NOTE: Building the compiler with DEBUG_NODE_XML specified takes up a lot of disk space. Case in point, when making r47639, the classes-node-dump.xml file is 26,962,823 bytes in size on x86_64-win64.
Tagscompiler, debug, patch
Fixed in Revision
FPCOldBugId
FPCTarget4.0.0
Attached Files

Activities

J. Gareth Moreton

2020-12-01 23:03

developer   ~0127311

Patch not ready. Needs reworking to properly merge with 0036882.

Pierre Muller

2020-12-07 08:32

developer   ~0127393

Resolved by applying patch #47709,
after exchanges between Gareth and myself.

  Thanks Gareth!

J. Gareth Moreton

2020-12-07 09:12

developer   ~0127394

I take it the last patch worked without a hitch! You're welcome Pierre.

Issue History

Date Modified Username Field Change
2020-12-01 07:03 J. Gareth Moreton New Issue
2020-12-01 07:03 J. Gareth Moreton File Added: node-dump-pass-1.patch
2020-12-01 07:03 J. Gareth Moreton Tag Attached: patch
2020-12-01 07:03 J. Gareth Moreton Tag Attached: compiler
2020-12-01 07:03 J. Gareth Moreton Tag Attached: debug
2020-12-01 07:04 J. Gareth Moreton Priority normal => low
2020-12-01 07:04 J. Gareth Moreton Severity minor => feature
2020-12-01 07:04 J. Gareth Moreton FPCTarget => -
2020-12-01 23:02 J. Gareth Moreton File Deleted: node-dump-pass-1.patch
2020-12-01 23:03 J. Gareth Moreton Note Added: 0127311
2020-12-07 08:32 Pierre Muller Assigned To => Pierre Muller
2020-12-07 08:32 Pierre Muller Status new => resolved
2020-12-07 08:32 Pierre Muller Resolution open => fixed
2020-12-07 08:32 Pierre Muller Fixed in Version => 3.3.1
2020-12-07 08:32 Pierre Muller FPCTarget - => 4.0.0
2020-12-07 08:32 Pierre Muller Note Added: 0127393
2020-12-07 09:12 J. Gareth Moreton Note Added: 0127394