projecttemplates doesn't use the template.lpi file for a new project
Original Reporter info from Mantis: RolfW @Rolf_Wetjen
-
Reporter name: Rolf Wetjen
Original Reporter info from Mantis: RolfW @Rolf_Wetjen
- Reporter name: Rolf Wetjen
Description:
My template has a customized file project1.lpi. Projecttemplates copies this file to the ProjDir (and all other files of course) but overwrites the lpi file with some defaults later. function TTemplateProjectDescriptor.InitProject in idetemplateproject.pp sets some defaults for AProject but doesn't take care of the settings from the existing lpi file (the template's one). So the template's lpi file is overwritten with the defaults set here.
My project.ini:
[Variables]
ProjDir=D:\Rolf\Lazarus\Rolf\Test<br/>
ProjName=project1
[Project]
Name=Test Anwendung
Author=Rolf Wetjen
Description=Eine Anwendung zum Testen
ProjectFile=project1
Recurse=0
Rolf
Mantis conversion info:
- Mantis ID: 38244
- OS: Windows 10
- Platform: x64
- Version: 2.0.10
- Fixed in revision: r64307 (#3f43cd26)
Designs
Relates to
- #39467Version 2.2
Activity
assigned to @JuhaManninen
added CategoryIDE Version2.0.10 WS: Win32/64 labels
Converted from Mantis. Note by Rolf Wetjen @Rolf_Wetjen
- Mantis submitter username: RolfW @Rolf_Wetjen
- Mantis submitter real name: Rolf Wetjen
Patch for Lazarus 2.1.0 / SVN 63089M attached. Solves this issue an some fine tuning.
Rolf-
Converted from Mantis. Note by Juha Manninen @JuhaManninen
- Mantis submitter username: JuhaManninen @JuhaManninen
- Mantis submitter real name: Juha Manninen
Looking at the code, your procedure FileReplaceText is very slow.
With sl: TStringList this piece of code :
sl.Text:=ReplaceText(sl.Text,AFrom,ATo);
first joins lines to one string, the runs ReplaceText, then splits the string again by NewLines for the StringList.
Iterating the list and replacing line by line may be faster. I didn't test yet, just looking it.
ReplaceText() calls StringReplace() which is slow as well, but should be OK here.BTW, we usually put used units in the interface section unless really needed in implementation section for cyclic dependency.
It makes following and designing dependencies easier and prevents accidental cyclic dependencies. -
Converted from Mantis. Note by Juha Manninen @JuhaManninen
- Mantis submitter username: JuhaManninen @JuhaManninen
- Mantis submitter real name: Juha Manninen
I applied it with minor changes. Please test.
Thanks for the patch. -
Converted from Mantis. Note by Rolf Wetjen @Rolf_Wetjen
- Mantis submitter username: RolfW @Rolf_Wetjen
- Mantis submitter real name: Rolf Wetjen
Tested ok.
Thanks, Rolf -
Attached files:
- projecttemplates.patch (Size: 7989 bytes, user: RolfW (Rolf Wetjen), date: 2020-12-26)
marked this issue as related to #39467 (closed)
RolfW, please see if you used the property ProjectFile correctly. See also if my fix for the related issue is OK.
The line
FProjectFile:='project'
was added by michael in 7c20c961 in 2008.
The commit message:- Updated README with copy of Tom Verhoeff
- Added additional key ProjectFile= Any file whose name (no extension) matches this, will be renamed to PROJNAME
- Improved variables dialog: when there is no message, the grid is disabled, and the message adapted accordingly
Hi Juha,
I can't remenber that I implemented something special for ProjectFile.
For the moment it's working this way: project.ini [Variables] ProjDir=D:\Rolf\Lazarus\Rolf\Test
ProjName=test1 MainUnit=unit11 [Project] Name=Test Anwendung für Windows Description=Eine Windows Anwendung zum Testen ProjectFile=project1 Recurse=0The project files in the template folder are project1.lpi, project1.lpr, project1.lps.
The template project create dialog (frmtemplatevariables) EProjectName field is prefilled with ProjName (test1) from project.ini and the new project files are test1.lpi, .lpr, .lps in this example. So, there's a rename based on the user input in frmtemplatevariables.
This is the 'old' default Lazarus implementation and I didn't change it as far as I remember.
Maybe I missunderstood something. For me it seems that project.ini|ProjName and project.ini|ProjectFile variables both want to rename the same set of project files. May be the missing point is to set the TProjectTemplate|ProjectFile property based on project.ini|ProjName instead of project.ini|ProjectFile. If so, the projectini|ProjectFile variable isn't needed anymore and the documentation needs a change too. Something is duplicate here?!
Regards,
Rolf (RolfW)
...
Am 17.11.2021 um 09:23 schrieb Juha Manninen (@JuhaManninen):
GitLab
Juha Manninen https://gitlab.com/JuhaManninen commented #38244 (comment 735369719):
RolfW, please see if you used the property ProjectFile correctly. See also if my fix for the related issue is OK.
The line |FProjectFile:='project'| was added by michael in 7c20c961 7c20c961 in 2008. The commit message:
- Updated README with copy of Tom Verhoeff
- Added additional key ProjectFile= Any file whose name (no extension) matches this, will be renamed to PROJNAME
- Improved variables dialog: when there is no message, the grid is disabled, and the message adapted accordingly
— Reply to this email directly or view it on GitLab #38244 (comment 735369719).
You're receiving this email because of your account on gitlab.com. If you'd like to receive fewer emails, you can unsubscribe https://gitlab.com/-/sent_notifications/REDACTED/unsubscribe from this thread or adjust your notification settings.
removed WS: Win32/64 label
added StatusFeedback label
removed StatusFeedback label
Hi Juha,
meanwhile I've verified the code. It's working exactly as described in in projecttemplates wiki (https://wiki.freepascal.org/Project_Templates). Anyway, I've attached two small patches:
frmtemplatevariables.patch Allows to prefill the variables in ProjectVariablesForm from project.ini. [Variables] VarName1=Description 1[|Value1] Don't know who may change the wiki?
projecttemplates.patch ProjectFile in project.ini isn't mandatory. The first *.lpi file will be taken as ProjectFile if it's not specified or ProjectFile.lpi doesn't exist. A suggestion to change the wiki for a clarification of ProjName and ProjFile:
ProjName: The filename (no extension) of the new project files in ProjDir.
ProjectFile
Filename (no extension) of the project files in the templates folder. All files ProjectFile.* will be copied to the folder of the new created project (ProjDir) and renamed to the new project name (ProjName). ProjectFile is not mandatory. The first *.lpi file in the trmplate folder will be taken for ProjectFile if it's not specified or if ProjectFile.lpi doesn't exist.
Regards Rolf
mentioned in commit 08ed2844
-
Applied, thanks.
I declaredsr: TSearchRec;in var section and usedExtractFileNameOnly(sr.Name)in one place. I wonder how it compiled for you without sr declared.Don't know who may change the wiki?
You.
The idea of a wiki page is that anybody involved can change it. You know best what your own changes do, so...Sorry, I've no idea how to reopen the issue.
Up in this page there is a "Close" button. It will say "Reopen" once this issue is closed (after reloading the page). You can close this when you feel the ProjectTemplates pkg is good, and see it yourself.
Or does reopening require a developer status? Not sure. mentioned in commit f7b5b14c
