Lazarus hanging when lHelp starts from Menu and by F1 pressing
Original Reporter info from Mantis: seniorandre
-
Reporter name: Andrey Sobol
Original Reporter info from Mantis: seniorandre
- Reporter name: Andrey Sobol
Description:
Issue description:
Lazarus IDE creates two instances of TChmHelpViewer object on start. As result we can`t start chm help from Help menu and from context search by F1 at the same time. That is I start the lHelp at first from menu, next I do a roll down (minimaze) the lHelp (not close) and press F1 for context search, I get a hanging IDE. IDE does starting another instance of IPC server with same IPC ID. That occurs because each instance of TChmHelpViewer has own THelpConnector with same IPC ID. The reverse situation also exists. F1 - minimaze lHelp - choose Help menu - crash.
Fixes:
- I done a singleton for TChmHelpViewer object instance.
- Moved a checking of rebuild lHelp to after checking connection (for uniformity).
- Made a starting of lHelp on each choosing of help menu for display full help.
I Think it fix and the fix (tranc rev.64159) need transfer to fixes_2_0 branch it is terrible mistakes.
Patch attached
Mantis conversion info:
- Mantis ID: 38276
- OS: Windows
- OS Build: Win10
- Build: trunc and 2.0.10
- Platform: i386
- Version: 2.0.10
- Fixed in revision: r64306 (#9cc89367)