View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0038296||Lazarus||IDE||public||2021-01-03 03:30||2021-04-06 05:54|
|Reporter||Bambang Pranoto||Assigned To||Michl|
|Fixed in Version||2.1 (SVN)|
|Summary||0038296: IDE with AnchorDockingDesgn cannot close cloned source editor|
|Description||With lazarus ide compiled with AnchorDockingDsgn, I cannot delete cloned source editor. Pressing the Close control button just brings to back the windows, but the cloned source editor still exists|
On plain ide without AnchorDockingDsgn, the cloned source editor can be closed.
|Steps To Reproduce||1. Install AnchorDockingDsgn package to make the IDE docked.|
2. On the source editor, right click on file name tab and click "Clone to New Window"
3. A cloned source editor will created.
4. Try to close the cloned source editor, it will go to the background, but it will be still there.
|Tags||No tags attached.|
|Fixed in Revision||64798, 64805, 64813, 64815|
Fixed in Trunk revision 64798. Tested on Windows7, Linux Mint KDE GTK2, Qt.
You have now a option "Free window on close". If you enable it, the source editor window is now closed.
Please try and close if ok.
This break docking (closed window not remove spliters if "free window on close" set to true) see components\anchordocking\minide
Tested in windows
In addition to previous comment, I have a question.
Are you really sure that "Free window on close" should be an option at all? Sounds like it is exposing internal implementation detail.
> This break docking (closed window not remove spliters if "free window on close" set to true) see components\anchordocking\minide
> Tested in windows
Thank you for that hint! I was mainly focused on Lazarus. I see it.
> Are you really sure that "Free window on close" should be an option at all? Sounds like it is exposing internal implementation detail.
I think, I can fix this issue without that option, but if you want to open a window what is really "new", how do you make it without such a option? You always got the hidden window reopened. In Source Editor this behaviour was implemented before - it is freed e.g. when there is just one file opened or user want it.
> but if you want to open a window what is really "new", how do you make it without such a option?
What does this option change in behavior from the user's POV? In which cases should user switch it off? Should he at all?
Anyway, it seems to me that this option either should be reworded to reflect its behavior from the user's POV or removed (replaced by some menu item "Open new" or something). IMO normal users won't be able to understand its meaning in the current form.
> Anyway, it seems to me that this option either should be reworded to reflect its behavior from the
> user's POV or removed (replaced by some menu item "Open new" or something). IMO normal users
> won't be able to understand its meaning in the current form.
Yes, you are right! That behaviour is not clear for end user and open a new clean window can be organized otherwise. I reverted all these changes in revision 64813.
I fixed the issue in a other way in revision 64815.
@Andrey Zubarev: Can you please test?
||Yes, AnchorDocking now work. Thanks!|
@Andrey Zubarev and Maxim Ganetsky: Thank you for testing and pushing me in the right direction!
@Bambang Pranoto: Please test with Lazarus Trunk and close if OK.
||Yes, it works in the trunk version.|
|2021-01-03 03:30||Bambang Pranoto||New Issue|
|2021-03-13 23:35||Michl||Assigned To||=> Michl|
|2021-03-13 23:35||Michl||Status||new => assigned|
|2021-03-13 23:39||Michl||Fixed in Revision||=> 64798|
|2021-03-13 23:39||Michl||LazTarget||=> -|
|2021-03-13 23:50||Michl||Status||assigned => resolved|
|2021-03-13 23:50||Michl||Resolution||open => fixed|
|2021-03-13 23:50||Michl||Fixed in Version||=> 2.1 (SVN)|
|2021-03-13 23:50||Michl||Note Added: 0129638|
|2021-03-14 14:44||Michl||Fixed in Revision||64798 => 64798, 64805|
|2021-03-14 20:53||Andrey Zubarev||Note Added: 0129666|
|2021-03-14 20:53||Andrey Zubarev||Note Edited: 0129666||View Revisions|
|2021-03-14 21:35||Maxim Ganetsky||Status||resolved => assigned|
|2021-03-14 21:35||Maxim Ganetsky||Resolution||fixed => open|
|2021-03-14 21:39||Maxim Ganetsky||Note Added: 0129667|
|2021-03-14 22:33||Michl||Note Added: 0129670|
|2021-03-14 23:22||Maxim Ganetsky||Note Added: 0129674|
|2021-03-15 01:27||Michl||Note Added: 0129675|
|2021-03-15 01:29||Michl||Note Added: 0129676|
|2021-03-15 01:29||Michl||Fixed in Revision||64798, 64805 => 64798, 64805, 64813, 64815|
|2021-03-15 01:29||Michl||Status||assigned => feedback|
|2021-03-15 06:39||Andrey Zubarev||Note Added: 0129677|
|2021-03-15 09:26||Michl||Status||feedback => resolved|
|2021-03-15 09:26||Michl||Resolution||open => fixed|
|2021-03-15 09:26||Michl||Note Added: 0129679|
|2021-04-03 23:14||Michl||Relationship added||related to 0038699|
|2021-04-06 05:54||Bambang Pranoto||Status||resolved => closed|
|2021-04-06 05:54||Bambang Pranoto||Note Added: 0130129|