View Issue Details

IDProjectCategoryView StatusLast Update
0038371FPCCompilerpublic2021-01-19 22:05
ReporterJ. Gareth Moreton Assigned ToFlorian  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
PlatformCross-platform (tested on arm64)OSLInux (Raspberry Pi OS) 
Product Version3.3.1 
Summary0038371: [Patch] Unitialized result variable fix on non-x86 debug builds
DescriptionThis patch fixes an uninitialized Result variable when building the compiler with DEBUG_NODE_XML on non-x86 platforms (e.g. aarch64).
Steps To ReproduceApply patch and confirm successful compilation on aarch64 and other non-x86 platforms when -dDEBUG_NODE_XML is specified
TagsNo tags attached.
Fixed in Revision48221
FPCOldBugId
FPCTarget-
Attached Files

Activities

J. Gareth Moreton

2021-01-19 21:28

developer   ~0128434

Also... silly mistake! Patch updated.
debug-xml-formatop-fix.patch (476 bytes)   
Index: compiler/nbas.pas
===================================================================
--- compiler/nbas.pas	(revision 48130)
+++ compiler/nbas.pas	(working copy)
@@ -1023,8 +1023,8 @@
                   if segment <> NR_NO then
                     Result := gas_regname(segment) + ':'
                   else
+{$endif defined(x86)}
                     Result := '';
-{$endif defined(x86)}
 
                   if Assigned(symbol) then
                     begin

Florian

2021-01-19 22:05

administrator   ~0128436

Thanks, applied.

Issue History

Date Modified Username Field Change
2021-01-19 08:33 J. Gareth Moreton New Issue
2021-01-19 08:33 J. Gareth Moreton File Added: debug-xml-formatop-fix.patch
2021-01-19 21:27 J. Gareth Moreton File Deleted: debug-xml-formatop-fix.patch
2021-01-19 21:28 J. Gareth Moreton Note Added: 0128434
2021-01-19 21:28 J. Gareth Moreton File Added: debug-xml-formatop-fix.patch
2021-01-19 22:05 Florian Assigned To => Florian
2021-01-19 22:05 Florian Status new => resolved
2021-01-19 22:05 Florian Resolution open => fixed
2021-01-19 22:05 Florian Fixed in Revision => 48221
2021-01-19 22:05 Florian FPCTarget => -
2021-01-19 22:05 Florian Note Added: 0128436