View Issue Details

IDProjectCategoryView StatusLast Update
0038528LazarusPackagespublic2021-02-22 11:26
ReporterKevin Jesshope Assigned ToJuha Manninen  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
PlatformLazarus IDE v2.1.0OSWin64 
Product Version2.1 (SVN) 
Summary0038528: StrStarts should be StrEnds
DescriptionLatest update to ToDoListCore.pas R64527 line 372 has

  // Remove the ending comment chars from input string
  if (aEndComment <> '') and StartsStr(aEndComment, lParsingString) then
    SetLength(lParsingString, Length(lParsingString)-Length(aEndComment));

The StartsStr should be EndsStr. StartsStr results in the aEndComment not being found and hence not removed so the todolist dialog includes the EndComment '}'
Steps To ReproduceRunning lazarus\components\todolist\test\TestToDoList.lpi fails when StartsStr is used. All tests are passed if EndsStr is used.
TagsNo tags attached.
Fixed in Revisionr64648
LazTarget-
WidgetsetWin32/Win64
Attached Files

Activities

Juha Manninen

2021-02-22 10:52

developer   ~0129087

Oops, yes. I fixed it and harmonized the uses section.
Please test.

Kevin Jesshope

2021-02-22 11:26

reporter   ~0129090

Passes the unit tests and confirmed fixed in the IDE.

Issue History

Date Modified Username Field Change
2021-02-22 08:26 Kevin Jesshope New Issue
2021-02-22 08:26 Kevin Jesshope Issue generated from: 0036914
2021-02-22 10:36 Juha Manninen Assigned To => Juha Manninen
2021-02-22 10:36 Juha Manninen Status new => assigned
2021-02-22 10:52 Juha Manninen Status assigned => resolved
2021-02-22 10:52 Juha Manninen Resolution open => fixed
2021-02-22 10:52 Juha Manninen Fixed in Revision => r64648
2021-02-22 10:52 Juha Manninen LazTarget => -
2021-02-22 10:52 Juha Manninen Widgetset Win32/Win64 => Win32/Win64
2021-02-22 10:52 Juha Manninen Note Added: 0129087
2021-02-22 11:26 Kevin Jesshope Note Added: 0129090