LCLTaskDialog prevent \n conversion to LF

Original Reporter info from Mantis: zamtmn @zamtmn

• Reporter name: Andrey Zubarev

Description:

here https://forum.lazarus.freepascal.org/index.php/topic,53884.0.html
Attached path add escaped \ processing

Mantis conversion info:

• Mantis ID: 38676
• Fixed in version: 2.2
• Fixed in revision: 64975 (#058e8264)
• Target version: 2.2

assigned to @ganmax

added CategoryLCL label

changed milestone to %Version 2.2

Converted from Mantis. Note by Andrey Zubarev @zamtmn

• Mantis submitter username: zamtmn @zamtmn
• Mantis submitter real name: Andrey Zubarev

---

Converted from Mantis. Note by Maxim Ganetsky @ganmax

• Mantis submitter username: Maxim @ganmax
• Mantis submitter real name: Maxim Ganetsky

---

I am afraid, this patch won't be applied. It makes user to escape every \ symbol which is unpascalish.

Better to remove handling of \n in Content field at all. In this case users will need to use 'LineEnding' constant in order to get multilined string. Such a patch WILL be applied.

Converted from Mantis. Note by Andrey Zubarev @zamtmn

• Mantis submitter username: zamtmn @zamtmn
• Mantis submitter real name: Andrey Zubarev

---

It makes user to escape every \ symbol which is unpascalish.
no only \n escape to \n if not need line feed, otherwise, the behavior remains the same
It makes user to escape every \ to \\ оr \\

I think this option is the only one that will keep the old code working

Converted from Mantis. Note by Maxim Ganetsky @ganmax

• Mantis submitter username: Maxim @ganmax
• Mantis submitter real name: Maxim Ganetsky

---

It makes user to escape every \ to \\ оr \\

That's the point, the change is already backwards incompatible. Moreover, users will need to review their strings and escape '' if 'n' is present after it if needed. In practice it will be easier to always escape '' as it will not be always possible to predict if 'n' will follow '' or not.

The current behavior is considered buggy and we don't want it to be default, so there is simply no backwards compatible way out, because users may rely on it. So better to bite the bullet and remove handling of \n in Content field at all. Inserting newlines will be achieved using LineEnding constants then.

Converted from Mantis. Note by Maxim Ganetsky @ganmax

• Mantis submitter username: Maxim @ganmax
• Mantis submitter real name: Maxim Ganetsky

---

Please test and close if OK, '\n' sequence is not converted in Content field anymore.

Converted from Mantis. Note by Andrey Zubarev @zamtmn

• Mantis submitter username: zamtmn @zamtmn
• Mantis submitter real name: Andrey Zubarev

---

Thanks!

closed

locked this issue

Attached files:

• lcltaskdialog.pas.patch (Size: 758 bytes, user: zamtmn (Andrey Zubarev), date: 2021-03-28)

mentioned in commit 15989485

mentioned in commit 4be2e3a7